From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Samarth Narang" <samarth.colleges@gmail.com>
Cc: sashiko-bot@kernel.org, "Han Xu" <han.xu@nxp.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
sashiko-reviews@lists.linux.dev,
"Richard Weinberger" <richard@nod.at>,
imx@lists.linux.dev, linux-mtd@lists.infradead.org,
Frank.Li@kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: gpmi: terminate the DMA chain on completion timeout
Date: Mon, 16 Nov 2026 14:58:59 +0100 [thread overview]
Message-ID: <87jymcswrg.fsf@bootlin.com> (raw)
In-Reply-To: <87pkw4sx1v.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 16 Nov 2026 14:52:44 +0100")
On 16/11/2026 at 14:52:44 +01, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> On 30/10/2026 at 15:20:32 GMT, sashiko-bot@kernel.org wrote:
>
>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> - [Medium] mtd: rawnand: gpmi: unsynchronized DMA termination in
>> gpmi_nfc_exec_op()
>
> Sashiko complaint looks legitimate, since you haven't actually run into
> that problem, I believe the fix is incorrect on this platform and
> therefore a DMA patch must be sent first. I will drop this patch, please
> resend once the DMA part fixed.
Please answer to your previous patches, stating why I should not
consider them for review when you send another series including them.
I will in the end consider this patch -in other series- for appliance,
because the fix seems correct on the NAND side, but is still probably
not working as expected on the DMA side.
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Samarth Narang" <samarth.colleges@gmail.com>
Cc: sashiko-bot@kernel.org, "Han Xu" <han.xu@nxp.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
sashiko-reviews@lists.linux.dev,
"Richard Weinberger" <richard@nod.at>,
imx@lists.linux.dev, linux-mtd@lists.infradead.org,
Frank.Li@kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: gpmi: terminate the DMA chain on completion timeout
Date: Mon, 16 Nov 2026 14:58:59 +0100 [thread overview]
Message-ID: <87jymcswrg.fsf@bootlin.com> (raw)
In-Reply-To: <87pkw4sx1v.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 16 Nov 2026 14:52:44 +0100")
On 16/11/2026 at 14:52:44 +01, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> On 30/10/2026 at 15:20:32 GMT, sashiko-bot@kernel.org wrote:
>
>> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>> - [Medium] mtd: rawnand: gpmi: unsynchronized DMA termination in
>> gpmi_nfc_exec_op()
>
> Sashiko complaint looks legitimate, since you haven't actually run into
> that problem, I believe the fix is incorrect on this platform and
> therefore a DMA patch must be sent first. I will drop this patch, please
> resend once the DMA part fixed.
Please answer to your previous patches, stating why I should not
consider them for review when you send another series including them.
I will in the end consider this patch -in other series- for appliance,
because the fix seems correct on the NAND side, but is still probably
not working as expected on the DMA side.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-11-16 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 15:09 [PATCH v2] mtd: rawnand: gpmi: terminate the DMA chain on completion timeout Samarth Narang
2026-10-30 15:09 ` Samarth Narang
2026-10-30 15:20 ` sashiko-bot
2026-10-30 15:20 ` sashiko-bot
2026-11-16 13:52 ` Miquel Raynal
2026-11-16 13:52 ` Miquel Raynal
2026-11-16 13:58 ` Miquel Raynal [this message]
2026-11-16 13:58 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jymcswrg.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=Frank.Li@kernel.org \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=samarth.colleges@gmail.com \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.