[Buildroot] [PATCH] .b4-config: add patchwork configuration

[Buildroot] [PATCH] .b4-config: add patchwork configuration

[Arnout Vandecappelle via buildroot]

This allows maintainers to use b4 to update patchwork.

- Use git config --global b4.pw-key <key> to set the patchwork token.
- Use git config b4.thanks-am-template <filename> to point to a template
  for thank-you mails.
- Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
  "Under Review".
- Use b4 ty -a to prepare (and optionally send with -S) the thank-you
  mail, and update patchwork to "Accepted".

Without pw-key, b4 doesn't touch patchwork at all, so non-maintainers
can safely keep using b4.

Signed-off-by: Arnout Vandecappelle <arnout@rnout.be>
---
 .b4-config | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.b4-config b/.b4-config
index d568669864..9fa518d02a 100644
--- a/.b4-config
+++ b/.b4-config
@@ -4,5 +4,9 @@
     send-series-to = buildroot@buildroot.org
     send-auto-cc-cmd = "./utils/get-developers -e -"
     prep-perpatch-check-cmd = "./utils/check-package -q -p -"
+    pw-url = https://patchwork.buildroot.org
+    pw-project = buildroot
+    pw-review-state = under-review
+    pw-accept-state = accepted
 
 # vim: set filetype=gitconfig:
-- 
2.56.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 > This allows maintainers to use b4 to update patchwork.
 > - Use git config --global b4.pw-key <key> to set the patchwork token.

NIT: Why globally?

> - Use git config b4.thanks-am-template <filename> to point to a template
 >   for thank-you mails.
 > - Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
 >   "Under Review".
 > - Use b4 ty -a to prepare (and optionally send with -S) the thank-you
 >   mail, and update patchwork to "Accepted".

It would maybe have been worth mentioning that this is a new feature in
b4 0.15 and ignored by earlier versions.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration

[Arnout Vandecappelle via buildroot]

On 10/10/2026 16:55, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
> 
>   > This allows maintainers to use b4 to update patchwork.
>   > - Use git config --global b4.pw-key <key> to set the patchwork token.
> 
> NIT: Why globally?

  No good reason.

>> - Use git config b4.thanks-am-template <filename> to point to a template
>   >   for thank-you mails.
>   > - Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
>   >   "Under Review".
>   > - Use b4 ty -a to prepare (and optionally send with -S) the thank-you
>   >   mail, and update patchwork to "Accepted".
> 
> It would maybe have been worth mentioning that this is a new feature in
> b4 0.15 and ignored by earlier versions.
  It works with my 0.14.3 in Fedora...

  BTW a few additional things I discovered:

- it doesn't do the From: rewriting like patchwork does. I do an additional sed 
to handle that;

- for the same reason, you have to add -S to correctly handle Reviewed-by etc. 
tags, otherwise it gives an error when the tag doesn't match the From;

- if the patch is part of a series, shazam downloads the entire series unless 
you give --single-message;

- b4 ty gives only a single reply to a series. It does mark everything as 
accepted in patchwork.


  So a bit of a mixed bag :-(. Time to patch b4?


  Regards,
  Arnout

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@rnout.be> writes:

 > On 10/10/2026 16:55, Peter Korsgaard wrote:
 >>>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
 >> > This allows maintainers to use b4 to update patchwork.
 >> > - Use git config --global b4.pw-key <key> to set the patchwork token.
 >> NIT: Why globally?

 >  No good reason.

 >>> - Use git config b4.thanks-am-template <filename> to point to a template
 >> >   for thank-you mails.
 >> > - Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
 >> >   "Under Review".
 >> > - Use b4 ty -a to prepare (and optionally send with -S) the thank-you
 >> >   mail, and update patchwork to "Accepted".
 >> It would maybe have been worth mentioning that this is a new feature
 >> in
 >> b4 0.15 and ignored by earlier versions.
 >  It works with my 0.14.3 in Fedora...

I'll give it another try, possibly I did something wrong. It is listed
in the 0.15 changelog though.


 >  BTW a few additional things I discovered:

 > - it doesn't do the From: rewriting like patchwork does. I do an
 >   additional sed to handle that;

 > - for the same reason, you have to add -S to correctly handle
 >   Reviewed-by etc. tags, otherwise it gives an error when the tag
 >  doesn't match the From;

 > - if the patch is part of a series, shazam downloads the entire series
 >   unless you give --single-message;

 > - b4 ty gives only a single reply to a series. It does mark everything
 >   as accepted in patchwork.

That part is probably OK, as long as the reply makes it clear that the
entire series is applied.


 >  So a bit of a mixed bag :-(. Time to patch b4?

Indeed. Maybe not a bad idea? It naturally does not fix it for the
distro packages for now though.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration

[Arnout Vandecappelle via buildroot]

On 10/10/2026 14:42, Arnout Vandecappelle wrote:
> This allows maintainers to use b4 to update patchwork.

  Since this is only relevant for maintainers, I decided to keep it out of 
b4-config and instead document it in

https://gitlab.com/buildroot.org/git-hooks/-/blob/master/MAINTAINERDOC.md

  All maintainers can freely update that document (no need for review).

  Regards,
  Arnout

> 
> - Use git config --global b4.pw-key <key> to set the patchwork token.
> - Use git config b4.thanks-am-template <filename> to point to a template
>    for thank-you mails.
> - Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
>    "Under Review".
> - Use b4 ty -a to prepare (and optionally send with -S) the thank-you
>    mail, and update patchwork to "Accepted".
> 
> Without pw-key, b4 doesn't touch patchwork at all, so non-maintainers
> can safely keep using b4.
> 
> Signed-off-by: Arnout Vandecappelle <arnout@rnout.be>
> ---
>   .b4-config | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/.b4-config b/.b4-config
> index d568669864..9fa518d02a 100644
> --- a/.b4-config
> +++ b/.b4-config
> @@ -4,5 +4,9 @@
>       send-series-to = buildroot@buildroot.org
>       send-auto-cc-cmd = "./utils/get-developers -e -"
>       prep-perpatch-check-cmd = "./utils/check-package -q -p -"
> +    pw-url = https://patchwork.buildroot.org
> +    pw-project = buildroot
> +    pw-review-state = under-review
> +    pw-accept-state = accepted
>   
>   # vim: set filetype=gitconfig:

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot