From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Steam Lin <STLin2@winbond.com>, Santhosh Kumar K <s-k6@ti.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 10/28] mtd: spinand: Make use of the operation templates through SPINAND_OP()
Date: Wed, 19 Nov 2025 18:23:33 +0100 [thread overview]
Message-ID: <87jyzmaqcq.fsf@bootlin.com> (raw)
In-Reply-To: <5680a2a8-aeb3-4274-a264-4ff658cc9246@linaro.org> (Tudor Ambarus's message of "Wed, 5 Nov 2025 17:28:29 +0100")
On 05/11/2025 at 17:28:29 +01, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
> On 10/31/25 6:26 PM, Miquel Raynal wrote:
>> index 4afebaf5f0195b9bc617ea1f125f637f76fff9f8..a8fd04a67cfa9925bd68c57539d86e0816b76274 100644
>> --- a/include/linux/mtd/spinand.h
>> +++ b/include/linux/mtd/spinand.h
>> @@ -701,6 +701,93 @@ struct spinand_device {
>> unsigned int retry_mode);
>> };
>>
>> +static inline struct spi_mem_op
>
> Do we still do inlines?
Defining functions in headers like that, I think yes? (static inline,
not just inline). The full line is something like:
+static inline struct spi_mem_op
+spinand_fill_reset_op(struct spinand_device *spinand)
+{
So it's not an inline declaration of a variable, but the definition of a
function (just saying, in case the diff mislead you).
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Pratyush Yadav <pratyush@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Steam Lin <STLin2@winbond.com>, Santhosh Kumar K <s-k6@ti.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 10/28] mtd: spinand: Make use of the operation templates through SPINAND_OP()
Date: Wed, 19 Nov 2025 18:23:33 +0100 [thread overview]
Message-ID: <87jyzmaqcq.fsf@bootlin.com> (raw)
In-Reply-To: <5680a2a8-aeb3-4274-a264-4ff658cc9246@linaro.org> (Tudor Ambarus's message of "Wed, 5 Nov 2025 17:28:29 +0100")
On 05/11/2025 at 17:28:29 +01, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
> On 10/31/25 6:26 PM, Miquel Raynal wrote:
>> index 4afebaf5f0195b9bc617ea1f125f637f76fff9f8..a8fd04a67cfa9925bd68c57539d86e0816b76274 100644
>> --- a/include/linux/mtd/spinand.h
>> +++ b/include/linux/mtd/spinand.h
>> @@ -701,6 +701,93 @@ struct spinand_device {
>> unsigned int retry_mode);
>> };
>>
>> +static inline struct spi_mem_op
>
> Do we still do inlines?
Defining functions in headers like that, I think yes? (static inline,
not just inline). The full line is something like:
+static inline struct spi_mem_op
+spinand_fill_reset_op(struct spinand_device *spinand)
+{
So it's not an inline declaration of a variable, but the definition of a
function (just saying, in case the diff mislead you).
Thanks,
Miquèl
next prev parent reply other threads:[~2025-11-19 17:23 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 17:26 [PATCH 00/28] mtd: spinand: Octal DTR support Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-10-31 17:26 ` [PATCH 01/28] spi: spi-mem: Make the DTR command operation macro more suitable Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 15:35 ` Tudor Ambarus
2025-11-05 15:35 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 02/28] spi: spi-mem: Create a repeated address operation Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 15:43 ` Tudor Ambarus
2025-11-05 15:43 ` Tudor Ambarus
2025-11-19 17:10 ` Miquel Raynal
2025-11-19 17:10 ` Miquel Raynal
2025-11-20 8:49 ` Tudor Ambarus
2025-11-20 8:49 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 03/28] spi: spi-mem: Limit octal DTR constraints to octal DTR situations Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 15:53 ` Tudor Ambarus
2025-11-05 15:53 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 04/28] mtd: spinand: Fix kernel doc Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 15:57 ` Tudor Ambarus
2025-11-05 15:57 ` Tudor Ambarus
2025-11-19 17:18 ` Miquel Raynal
2025-11-19 17:18 ` Miquel Raynal
2025-11-20 8:05 ` Tudor Ambarus
2025-11-20 8:05 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 05/28] mtd: spinand: Add missing check Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:04 ` Tudor Ambarus
2025-11-05 16:04 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 06/28] mtd: spinand: Remove stale definitions Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:05 ` Tudor Ambarus
2025-11-05 16:05 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 07/28] mtd: spinand: Use standard return values Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:06 ` Tudor Ambarus
2025-11-05 16:06 ` Tudor Ambarus
2025-11-19 17:20 ` Miquel Raynal
2025-11-19 17:20 ` Miquel Raynal
2025-10-31 17:26 ` [PATCH 08/28] mtd: spinand: Decouple write enable and write disable operations Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:08 ` Tudor Ambarus
2025-11-05 16:08 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 09/28] mtd: spinand: Create an array of operation templates Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:17 ` Tudor Ambarus
2025-11-05 16:17 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 10/28] mtd: spinand: Make use of the operation templates through SPINAND_OP() Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:28 ` Tudor Ambarus
2025-11-05 16:28 ` Tudor Ambarus
2025-11-19 17:23 ` Miquel Raynal [this message]
2025-11-19 17:23 ` Miquel Raynal
2025-11-20 8:35 ` Tudor Ambarus
2025-11-20 8:35 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 11/28] mtd: spinand: Convert vendor drivers to SPINAND_OP() Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:30 ` Tudor Ambarus
2025-11-05 16:30 ` Tudor Ambarus
2025-11-19 17:24 ` Miquel Raynal
2025-11-19 17:24 ` Miquel Raynal
2025-10-31 17:26 ` [PATCH 12/28] mtd: spinand: macronix: Convert vendor specific operation " Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:40 ` Tudor Ambarus
2025-11-05 16:40 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 13/28] mtd: spinand: winbond: Convert W25N " Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:40 ` Tudor Ambarus
2025-11-05 16:40 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 14/28] mtd: spinand: winbond: Convert W35N " Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-11-05 16:41 ` Tudor Ambarus
2025-11-05 16:41 ` Tudor Ambarus
2025-10-31 17:26 ` [PATCH 15/28] mtd: spinand: List vendor specific operations and make sure they are supported Miquel Raynal
2025-10-31 17:26 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 16/28] mtd: spinand: macronix: Register vendor specific operation Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 17/28] mtd: spinand: winbond: Register W25N " Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 18/28] mtd: spinand: winbond: Register W35N " Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 19/28] mtd: spinand: winbond: Fix style Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 20/28] mtd: spinand: winbond: Rename IO_MODE register macro Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 21/28] mtd: spinand: winbond: Configure the IO mode after the dummy cycles Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 22/28] mtd: spinand: Gather all the bus interface steps in one single function Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 23/28] mtd: spinand: Add support for setting a bus interface Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 24/28] mtd: spinand: Propagate the bus interface across core helpers Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 25/28] mtd: spinand: Give the bus interface to the configuration helper Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 26/28] mtd: spinand: Warn if using SSDR-only vendor commands in a non SSDR mode Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 27/28] mtd: spinand: Add octal DTR support Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
2025-10-31 17:27 ` [PATCH 28/28] mtd: spinand: winbond: W35N " Miquel Raynal
2025-10-31 17:27 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyzmaqcq.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=STLin2@winbond.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=s-k6@ti.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.