From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/3] xen: common: add ability to enable stack protector
Date: Tue, 26 Nov 2024 11:33:20 +0000 [thread overview]
Message-ID: <87jzcqjklc.fsf@epam.com> (raw)
In-Reply-To: <20d65a5d-dfdc-4622-b066-fc6de705af57@xen.org> (Julien Grall's message of "Mon, 25 Nov 2024 20:36:22 +0000")
Hi Julien,
Julien Grall <julien@xen.org> writes:
> Hi,
>
> Hi Volodymyr,
>
> On 22/11/2024 21:07, Volodymyr Babchuk wrote:
>> diff --git a/xen/include/xen/stack_protector.h b/xen/include/xen/stack_protector.h
>> new file mode 100644
>> index 0000000000..97f1eb5ac0
>> --- /dev/null
>> +++ b/xen/include/xen/stack_protector.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +
>> +#ifndef XEN__STACK_PROTECTOR_H
>> +#define XEN__STACK_PROTECTOR_H
>> +
>> +#ifdef CONFIG_STACKPROTECTOR
>> +
>> +#ifndef CONFIG_X86
>> +extern unsigned long __stack_chk_guard;
>
> Is this variable meant to change after boot? If not, then can you tag
> it with __ro_after_init?
>
No, changing it after boot will lead to a random panic. So yes, it is good
idea to make it RO.
--
WBR, Volodymyr
next prev parent reply other threads:[~2024-11-26 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 21:07 [PATCH 0/3] Add stack protector Volodymyr Babchuk
2024-11-22 21:07 ` [PATCH 1/3] xen: common: add ability to enable " Volodymyr Babchuk
2024-11-25 12:24 ` Andrew Cooper
2024-11-25 20:36 ` Julien Grall
2024-11-26 11:33 ` Volodymyr Babchuk [this message]
2024-11-22 21:07 ` [PATCH 2/3] xen: arm: enable stack protector feature Volodymyr Babchuk
2024-11-22 21:07 ` [PATCH 3/3] xen: riscv: " Volodymyr Babchuk
2024-11-25 8:43 ` Jan Beulich
2024-11-25 10:08 ` oleksii.kurochko
2024-11-23 7:41 ` [PATCH 0/3] Add stack protector Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzcqjklc.fsf@epam.com \
--to=volodymyr_babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.