From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"npiggin@gmail.com" <npiggin@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Muchun Song <muchun.song@linux.dev>,
Dan Williams <dan.j.williams@intel.com>,
Oscar Salvador <osalvador@suse.de>, Will Deacon <will@kernel.org>,
Joao Martins <joao.m.martins@oracle.com>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v4 03/13] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override
Date: Tue, 11 Jul 2023 09:55:34 +0530 [thread overview]
Message-ID: <87jzv7oz0h.fsf@linux.ibm.com> (raw)
In-Reply-To: <baba8fee-07dc-251e-3e26-a860d67c26a9@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 10/07/2023 à 18:08, Aneesh Kumar K.V a écrit :
>> dax vmemmap optimization requires a minimum of 2 PAGE_SIZE area within
>> vmemmap such that tail page mapping can point to the second PAGE_SIZE area.
>> Enforce that in vmemmap_can_optimize() function.
>>
>> Architectures like powerpc also want to enable vmemmap optimization
>> conditionally (only with radix MMU translation). Hence allow architecture
>> override.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Why renaming vmemmap_can_optimize() to __vmemmap_can_optimize() and keep
> it when vmemmap_can_optimize() has been override ? Is that because you
> expect overriding version of vmemmap_can_optimize() to call
> __vmemmap_can_optimize() ?
>
Yes, __vmemap_can_optimize will be used in patch 11
https://lore.kernel.org/linuxppc-dev/20230710160842.56300-12-aneesh.kumar@linux.ibm.com
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"npiggin@gmail.com" <npiggin@gmail.com>
Cc: Oscar Salvador <osalvador@suse.de>,
Mike Kravetz <mike.kravetz@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Muchun Song <muchun.song@linux.dev>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v4 03/13] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override
Date: Tue, 11 Jul 2023 09:55:34 +0530 [thread overview]
Message-ID: <87jzv7oz0h.fsf@linux.ibm.com> (raw)
In-Reply-To: <baba8fee-07dc-251e-3e26-a860d67c26a9@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 10/07/2023 à 18:08, Aneesh Kumar K.V a écrit :
>> dax vmemmap optimization requires a minimum of 2 PAGE_SIZE area within
>> vmemmap such that tail page mapping can point to the second PAGE_SIZE area.
>> Enforce that in vmemmap_can_optimize() function.
>>
>> Architectures like powerpc also want to enable vmemmap optimization
>> conditionally (only with radix MMU translation). Hence allow architecture
>> override.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Why renaming vmemmap_can_optimize() to __vmemmap_can_optimize() and keep
> it when vmemmap_can_optimize() has been override ? Is that because you
> expect overriding version of vmemmap_can_optimize() to call
> __vmemmap_can_optimize() ?
>
Yes, __vmemap_can_optimize will be used in patch 11
https://lore.kernel.org/linuxppc-dev/20230710160842.56300-12-aneesh.kumar@linux.ibm.com
-aneesh
next prev parent reply other threads:[~2023-07-11 4:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 16:08 [PATCH v4 00/13] Add support for DAX vmemmap optimization for ppc64 Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 01/13] mm/hugepage pud: Allow arch-specific helper function to check huge page pud support Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:16 ` Christophe Leroy
2023-07-10 17:16 ` Christophe Leroy
2023-07-10 16:08 ` [PATCH v4 02/13] mm: Change pudp_huge_get_and_clear_full take vm_area_struct as arg Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:17 ` Christophe Leroy
2023-07-10 17:17 ` Christophe Leroy
2023-07-10 16:08 ` [PATCH v4 03/13] mm/vmemmap: Improve vmemmap_can_optimize and allow architectures to override Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:20 ` Christophe Leroy
2023-07-10 17:20 ` Christophe Leroy
2023-07-11 4:25 ` Aneesh Kumar K.V [this message]
2023-07-11 4:25 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 04/13] mm/vmemmap: Allow architectures to override how vmemmap optimization works Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:26 ` Christophe Leroy
2023-07-10 17:26 ` Christophe Leroy
2023-07-11 4:27 ` Aneesh Kumar K.V
2023-07-11 4:27 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 05/13] mm: Add __HAVE_ARCH_PUD_SAME similar to __HAVE_ARCH_P4D_SAME Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:29 ` Christophe Leroy
2023-07-10 17:29 ` Christophe Leroy
2023-07-11 4:24 ` Aneesh Kumar K.V
2023-07-11 4:24 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 06/13] mm/huge pud: Use transparent huge pud helpers only with CONFIG_TRANSPARENT_HUGEPAGE Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:30 ` Christophe Leroy
2023-07-10 17:30 ` Christophe Leroy
2023-07-10 16:08 ` [PATCH v4 07/13] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 08/13] powerpc/mm/trace: Convert trace event to trace event class Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 17:32 ` Christophe Leroy
2023-07-10 17:32 ` Christophe Leroy
2023-07-10 16:08 ` [PATCH v4 09/13] powerpc/book3s64/mm: Enable transparent pud hugepage Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 10/13] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 11/13] powerpc/book3s64/radix: Add support for vmemmap optimization for radix Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 12/13] powerpc/book3s64/radix: Remove mmu_vmemmap_psize Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
2023-07-10 16:08 ` [PATCH v4 13/13] powerpc/book3s64/radix: Add debug message to give more details of vmemmap allocation Aneesh Kumar K.V
2023-07-10 16:08 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzv7oz0h.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.j.williams@intel.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=muchun.song@linux.dev \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.