All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: emu10k1: properly assert DSP init constraints
Date: Fri, 21 Apr 2023 17:23:28 +0200	[thread overview]
Message-ID: <87jzy5qmxb.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZEKnAqm5sh00Fx0j@ugly>

On Fri, 21 Apr 2023 17:08:50 +0200,
Oswald Buddenhagen wrote:
> 
> On Fri, Apr 21, 2023 at 05:05:28PM +0200, Takashi Iwai wrote:
> > On Fri, 21 Apr 2023 16:10:06 +0200,
> > Oswald Buddenhagen wrote:
> >> 
> >> If these are hit, we've already trashed kernel space. There is no
> >> recovery from that.
> >> 
> >> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> > 
> > Sorry, it's a big NO-NO.  BUG_ON() shouldn't be used here at all.
> > 
> > BUG_ON() is used for the case you inevitably must stop everything
> > immediately at this point.
> > 
> yes, this is exactly what is intended, and i hoped that the commit
> message makes it clear enough why.

Not clear at all.  Please explain in more details if we really *HAVE
TO* use BUG_ON() there.


thanks,

Takashi

      reply	other threads:[~2023-04-21 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 14:10 [PATCH] ALSA: emu10k1: properly assert DSP init constraints Oswald Buddenhagen
2023-04-21 15:05 ` Takashi Iwai
2023-04-21 15:08   ` Oswald Buddenhagen
2023-04-21 15:23     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzy5qmxb.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=oswald.buddenhagen@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.