From: Takashi Iwai <tiwai@suse.de>
To: Rob Herring <robh@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: Use of_property_read_bool() for boolean properties
Date: Wed, 19 Apr 2023 08:29:19 +0200 [thread overview]
Message-ID: <87jzy82xmo.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230418162557.GD1764573-robh@kernel.org>
On Tue, 18 Apr 2023 18:25:57 +0200,
Rob Herring wrote:
>
> On Fri, Mar 10, 2023 at 08:47:33AM -0600, Rob Herring wrote:
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties.
> > Convert reading boolean properties to to of_property_read_bool().
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > sound/ppc/tumbler.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ping!
Sorry for the oversight. Now both patches are applied.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Rob Herring <robh@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: Use of_property_read_bool() for boolean properties
Date: Wed, 19 Apr 2023 08:29:19 +0200 [thread overview]
Message-ID: <87jzy82xmo.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230418162557.GD1764573-robh@kernel.org>
On Tue, 18 Apr 2023 18:25:57 +0200,
Rob Herring wrote:
>
> On Fri, Mar 10, 2023 at 08:47:33AM -0600, Rob Herring wrote:
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties.
> > Convert reading boolean properties to to of_property_read_bool().
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > sound/ppc/tumbler.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ping!
Sorry for the oversight. Now both patches are applied.
Takashi
next prev parent reply other threads:[~2023-04-19 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:47 [PATCH] ALSA: Use of_property_read_bool() for boolean properties Rob Herring
2023-04-18 16:25 ` Rob Herring
2023-04-19 6:29 ` Takashi Iwai [this message]
2023-04-19 6:29 ` Takashi Iwai
2023-04-19 6:28 ` Takashi Iwai
2023-04-19 6:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzy82xmo.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.