From: Marc Zyngier <maz@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe
Date: Sat, 08 Apr 2023 11:39:27 +0100 [thread overview]
Message-ID: <87jzym64kg.wl-maz@kernel.org> (raw)
In-Reply-To: <20230327-irq-affinity-upstream-v2-1-1474e518f1cb@ti.com>
On Mon, 27 Mar 2023 16:04:26 +0100,
Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Simplify driver by allocating all VINTs at probe instead of
> allocating on IRQ request. This will allow dedicating few VINTs as
> direct IRQs without aggregation in future.
I think this is going in the wrong direction. Eager allocation is
wasting memory, slowing down boot, and in general a bad idea.
Why can't you just pre-allocate *one* interrupt that serves as a
chained handler for everything, and then use the rest of the interrupt
space for "direct" interrupts?
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe
Date: Sat, 08 Apr 2023 11:39:27 +0100 [thread overview]
Message-ID: <87jzym64kg.wl-maz@kernel.org> (raw)
In-Reply-To: <20230327-irq-affinity-upstream-v2-1-1474e518f1cb@ti.com>
On Mon, 27 Mar 2023 16:04:26 +0100,
Vignesh Raghavendra <vigneshr@ti.com> wrote:
>
> Simplify driver by allocating all VINTs at probe instead of
> allocating on IRQ request. This will allow dedicating few VINTs as
> direct IRQs without aggregation in future.
I think this is going in the wrong direction. Eager allocation is
wasting memory, slowing down boot, and in general a bad idea.
Why can't you just pre-allocate *one* interrupt that serves as a
chained handler for everything, and then use the rest of the interrupt
space for "direct" interrupts?
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-04-08 10:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 15:04 [PATCH RFC v2 0/2] irqchip: irq-ti-sci-inta: Add initial IRQ affinity support Vignesh Raghavendra
2023-03-27 15:04 ` Vignesh Raghavendra
2023-03-27 15:04 ` [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe Vignesh Raghavendra
2023-03-27 15:04 ` Vignesh Raghavendra
2023-04-08 10:39 ` Marc Zyngier [this message]
2023-04-08 10:39 ` Marc Zyngier
2023-04-08 11:34 ` Raghavendra, Vignesh
2023-04-08 11:34 ` Raghavendra, Vignesh
2023-03-27 15:04 ` [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped interrupts Vignesh Raghavendra
2023-03-27 15:04 ` Vignesh Raghavendra
2023-04-08 10:40 ` Marc Zyngier
2023-04-08 10:40 ` Marc Zyngier
2023-04-08 11:27 ` Raghavendra, Vignesh
2023-04-08 11:27 ` Raghavendra, Vignesh
2023-04-08 11:36 ` Marc Zyngier
2023-04-08 11:36 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzym64kg.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.