From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers
Date: Thu, 06 Apr 2023 11:05:44 +0200 [thread overview]
Message-ID: <87jzyp8jo7.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <f5f9fe8e-9df2-e201-b7f3-be717fa4bdb8@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
[...]
>>> +EXPORT_SYMBOL(__aperture_remove_legacy_vga_devices);
>>
>> I would just call this symbol aperture_remove_legacy_vga_devices() as
>> mentioned, the fact that aperture_remove_conflicting_pci_devices() use it
>> internally is an implementation detail IMO. But it's an exported symbol so
>> the naming should be consistent.
>
> That prefix __ is supposed to indicate that it's not a all-in-one
> solution. Most of all, it doesn't do sysfb_disable(). The helper is
> meant to be used as part of a larger function. I tried to outline this
> in the comment, where I say that drivers should first aquire framebuffer
> ownership and then call this helper. If naming isn't a showstopper, I'd
> like to keep the underscores.
>
Sure, I see that we have other symbols exported in DRM that have a __
prefix in their name. So maybe I am the one who was confused on the
meaning of it.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers
Date: Thu, 06 Apr 2023 11:05:44 +0200 [thread overview]
Message-ID: <87jzyp8jo7.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <f5f9fe8e-9df2-e201-b7f3-be717fa4bdb8@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
[...]
>>> +EXPORT_SYMBOL(__aperture_remove_legacy_vga_devices);
>>
>> I would just call this symbol aperture_remove_legacy_vga_devices() as
>> mentioned, the fact that aperture_remove_conflicting_pci_devices() use it
>> internally is an implementation detail IMO. But it's an exported symbol so
>> the naming should be consistent.
>
> That prefix __ is supposed to indicate that it's not a all-in-one
> solution. Most of all, it doesn't do sysfb_disable(). The helper is
> meant to be used as part of a larger function. I tried to outline this
> in the comment, where I say that drivers should first aquire framebuffer
> ownership and then call this helper. If naming isn't a showstopper, I'd
> like to keep the underscores.
>
Sure, I see that we have other symbols exported in DRM that have a __
prefix in their name. So maybe I am the one who was confused on the
meaning of it.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-04-06 9:05 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 20:18 [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` [Intel-gfx] [PATCH 2/8] video/aperture: use generic code to figure out the vga default device Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-05 11:27 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:27 ` Javier Martinez Canillas
2023-04-05 11:27 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 3/8] drm/aperture: Remove primary argument Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 21:20 ` [Intel-gfx] " Martin Blumenstingl
2023-04-04 21:20 ` Martin Blumenstingl
2023-04-04 21:20 ` Martin Blumenstingl
2023-04-04 21:20 ` Martin Blumenstingl
2023-04-04 21:20 ` Martin Blumenstingl
2023-04-05 9:25 ` [Intel-gfx] " Thierry Reding
2023-04-05 9:25 ` Thierry Reding
2023-04-05 9:25 ` Thierry Reding
2023-04-05 9:25 ` Thierry Reding
2023-04-05 9:25 ` Thierry Reding
2023-04-05 11:30 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:30 ` Javier Martinez Canillas
2023-04-05 11:30 ` Javier Martinez Canillas
2023-04-05 11:30 ` Javier Martinez Canillas
2023-04-05 11:30 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 4/8] video/aperture: Only kick vgacon when the pdev is decoding vga Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-05 11:31 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:31 ` Javier Martinez Canillas
2023-04-05 11:31 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 5/8] video/aperture: Move vga handling to pci function Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-05 11:34 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:34 ` Javier Martinez Canillas
2023-04-05 11:34 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 6/8] video/aperture: Drop primary argument Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-05 11:36 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:36 ` Javier Martinez Canillas
2023-04-05 11:36 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 7/8] video/aperture: Only remove sysfb on the default vga pci device Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-04 20:59 ` [Intel-gfx] " Aaron Plattner
2023-04-04 20:59 ` Aaron Plattner
2023-04-04 20:59 ` Aaron Plattner
2023-04-05 8:48 ` [Intel-gfx] " Daniel Vetter
2023-04-05 8:48 ` Daniel Vetter
2023-04-05 8:48 ` Daniel Vetter
2023-04-05 11:37 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:37 ` Javier Martinez Canillas
2023-04-05 11:37 ` Javier Martinez Canillas
2023-04-04 20:18 ` [Intel-gfx] [PATCH 8/8] fbdev: Simplify fb_is_primary_device for x86 Daniel Vetter
2023-04-04 20:18 ` Daniel Vetter
2023-04-05 11:40 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:40 ` Javier Martinez Canillas
2023-04-04 23:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers Patchwork
2023-04-04 23:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-04 23:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-05 7:49 ` [Intel-gfx] [PATCH 1/8] " Thomas Zimmermann
2023-04-05 7:49 ` Thomas Zimmermann
2023-04-05 8:05 ` [Intel-gfx] " Patrik Jakobsson
2023-04-05 8:05 ` Patrik Jakobsson
2023-04-05 8:15 ` [Intel-gfx] " Thomas Zimmermann
2023-04-05 8:15 ` Thomas Zimmermann
2023-04-05 8:07 ` [Intel-gfx] " Thomas Zimmermann
2023-04-05 8:07 ` Thomas Zimmermann
2023-04-05 8:59 ` [Intel-gfx] " Daniel Vetter
2023-04-05 8:59 ` Daniel Vetter
2023-04-05 9:26 ` [Intel-gfx] " Thomas Zimmermann
2023-04-05 9:26 ` Thomas Zimmermann
2023-04-05 9:38 ` [Intel-gfx] " Daniel Vetter
2023-04-05 9:38 ` Daniel Vetter
2023-04-05 11:00 ` [Intel-gfx] " Thomas Zimmermann
2023-04-05 11:00 ` Thomas Zimmermann
2023-04-05 11:16 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 11:16 ` Javier Martinez Canillas
2023-04-05 13:18 ` [Intel-gfx] " Daniel Vetter
2023-04-05 13:18 ` Daniel Vetter
2023-04-05 14:32 ` [Intel-gfx] " Thomas Zimmermann
2023-04-05 14:32 ` Thomas Zimmermann
2023-04-05 16:02 ` [Intel-gfx] " Daniel Vetter
2023-04-05 16:02 ` Daniel Vetter
2023-04-05 16:54 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 16:54 ` Javier Martinez Canillas
2023-04-05 17:14 ` [Intel-gfx] " Daniel Vetter
2023-04-05 17:14 ` Daniel Vetter
2023-04-05 17:43 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-05 17:43 ` Javier Martinez Canillas
2023-04-05 17:46 ` [Intel-gfx] " Patrik Jakobsson
2023-04-06 7:31 ` Daniel Vetter
2023-04-06 11:16 ` Patrik Jakobsson
2023-04-05 8:19 ` Thomas Zimmermann
2023-04-05 8:19 ` Thomas Zimmermann
2023-04-05 9:09 ` [Intel-gfx] " Daniel Vetter
2023-04-05 9:09 ` Daniel Vetter
2023-04-05 10:10 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/8] " Patchwork
2023-04-06 7:14 ` [Intel-gfx] [PATCH 1/8] " Thomas Zimmermann
2023-04-06 7:14 ` Thomas Zimmermann
2023-04-06 8:38 ` [Intel-gfx] " Javier Martinez Canillas
2023-04-06 8:38 ` Javier Martinez Canillas
2023-04-06 8:49 ` [Intel-gfx] " Thomas Zimmermann
2023-04-06 8:49 ` Thomas Zimmermann
2023-04-06 9:05 ` Javier Martinez Canillas [this message]
2023-04-06 9:05 ` Javier Martinez Canillas
2023-04-06 9:05 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzyp8jo7.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.