* [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency
@ 2023-02-28 22:07 Fabrice Fontaine
2023-02-28 22:07 ` [Buildroot] [PATCH 2/3] package/proftpd: add pcre2 " Fabrice Fontaine
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2023-02-28 22:07 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
libidn2 is an optional dependency which is enabled by default since
version 1.3.8 and
https://github.com/proftpd/proftpd/commit/5f61ac028e0930e7de9ea2a00864ccb6dc048f64
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/proftpd/proftpd.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/proftpd/proftpd.mk b/package/proftpd/proftpd.mk
index 8e7d108c9e..d3b6308185 100644
--- a/package/proftpd/proftpd.mk
+++ b/package/proftpd/proftpd.mk
@@ -27,6 +27,10 @@ PROFTPD_CONF_OPTS = \
--with-gnu-ld \
--without-openssl-cmdline
+ifeq ($(BR2_PACKAGE_LIBIDN2),y)
+PROFTPD_DEPENDENCIES += libidn2
+endif
+
ifeq ($(BR2_PACKAGE_PROFTPD_MOD_CAP),y)
PROFTPD_CONF_OPTS += --enable-cap
PROFTPD_DEPENDENCIES += libcap
--
2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 2/3] package/proftpd: add pcre2 optional dependency
2023-02-28 22:07 [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Fabrice Fontaine
@ 2023-02-28 22:07 ` Fabrice Fontaine
2023-03-05 18:36 ` Peter Korsgaard
2023-03-15 14:10 ` Peter Korsgaard
2023-02-28 22:07 ` [Buildroot] [PATCH 3/3] package/proftpd: needs dynamic library Fabrice Fontaine
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2023-02-28 22:07 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
pcre2 is an optional dependency since version 1.3.8 and
https://github.com/proftpd/proftpd/commit/e63cf016f574890c4096d587b8b1f55d87ac05d5
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/proftpd/proftpd.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/proftpd/proftpd.mk b/package/proftpd/proftpd.mk
index d3b6308185..398155222d 100644
--- a/package/proftpd/proftpd.mk
+++ b/package/proftpd/proftpd.mk
@@ -31,6 +31,13 @@ ifeq ($(BR2_PACKAGE_LIBIDN2),y)
PROFTPD_DEPENDENCIES += libidn2
endif
+ifeq ($(BR2_PACKAGE_PCRE2),y)
+PROFTPD_CONF_OPTS += --enable-pcre2
+PROFTPD_DEPENDENCIES += pcre2
+else
+PROFTPD_CONF_OPTS += --disable-pcre2
+endif
+
ifeq ($(BR2_PACKAGE_PROFTPD_MOD_CAP),y)
PROFTPD_CONF_OPTS += --enable-cap
PROFTPD_DEPENDENCIES += libcap
--
2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 3/3] package/proftpd: needs dynamic library
2023-02-28 22:07 [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Fabrice Fontaine
2023-02-28 22:07 ` [Buildroot] [PATCH 2/3] package/proftpd: add pcre2 " Fabrice Fontaine
@ 2023-02-28 22:07 ` Fabrice Fontaine
2023-03-05 18:36 ` Peter Korsgaard
2023-03-15 14:10 ` Peter Korsgaard
2023-03-05 18:36 ` [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Peter Korsgaard
2023-03-15 14:09 ` Peter Korsgaard
3 siblings, 2 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2023-02-28 22:07 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
proftpd doesn't build statically because it does not use pkg-config to
retrieve its dependencies since its addition in commit
5d173ec4122b89857e6d93fc337311b1f87631c9:
/tmp/instance-13/output-1/host/lib/gcc/arc-buildroot-linux-uclibc/10.2.0/../../../../arc-buildroot-linux-uclibc/bin/ld: /tmp/instance-13/output-1/host/arc-buildroot-linux-uclibc/sysroot/usr/lib/libidn2.a(libunistring_la-striconveh.o): in function `iconv_carefully_1':
buildroot/build/libidn2-2.3.4/unistring/striconveh.c:233: undefined reference to `libiconv'
[...]
/tmp/instance-5/output-1/host/lib/gcc/arceb-buildroot-linux-uclibc/10.2.0/../../../../arceb-buildroot-linux-uclibc/bin/ld: /tmp/instance-5/output-1/host/arceb-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a(bio_lib.o): in function `BIO_free':
bio_lib.c:(.text+0x3f2): undefined reference to `__atomic_fetch_sub_4'
Fixes:
- http://autobuild.buildroot.org/results/09f3f37b63dc68d31b18816b818df86fa3be095c
- http://autobuild.buildroot.org/results/2aba5297206e44dc086c3138ace70e85739196f3
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/proftpd/Config.in | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/proftpd/Config.in b/package/proftpd/Config.in
index 33ad2cea54..8ac1da3fed 100644
--- a/package/proftpd/Config.in
+++ b/package/proftpd/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_PROFTPD
bool "proftpd"
depends on BR2_USE_MMU # fork()
+ depends on !BR2_STATIC_LIBS
help
ProFTPD, a highly configurable FTP server.
@@ -105,3 +106,7 @@ config BR2_PACKAGE_PROFTPD_BUFFER_SIZE
0 uses the default size of 1024.
endif
+
+comment "proftpd needs a toolchain w/ dynamic library"
+ depends on BR2_USE_MMU
+ depends on BR2_STATIC_LIBS
--
2.39.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency
2023-02-28 22:07 [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Fabrice Fontaine
2023-02-28 22:07 ` [Buildroot] [PATCH 2/3] package/proftpd: add pcre2 " Fabrice Fontaine
2023-02-28 22:07 ` [Buildroot] [PATCH 3/3] package/proftpd: needs dynamic library Fabrice Fontaine
@ 2023-03-05 18:36 ` Peter Korsgaard
2023-03-15 14:09 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2023-03-05 18:36 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libidn2 is an optional dependency which is enabled by default since
> version 1.3.8 and
> https://github.com/proftpd/proftpd/commit/5f61ac028e0930e7de9ea2a00864ccb6dc048f64
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency
2023-02-28 22:07 [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Fabrice Fontaine
` (2 preceding siblings ...)
2023-03-05 18:36 ` [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Peter Korsgaard
@ 2023-03-15 14:09 ` Peter Korsgaard
3 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2023-03-15 14:09 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libidn2 is an optional dependency which is enabled by default since
> version 1.3.8 and
> https://github.com/proftpd/proftpd/commit/5f61ac028e0930e7de9ea2a00864ccb6dc048f64
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-15 14:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-28 22:07 [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Fabrice Fontaine
2023-02-28 22:07 ` [Buildroot] [PATCH 2/3] package/proftpd: add pcre2 " Fabrice Fontaine
2023-03-05 18:36 ` Peter Korsgaard
2023-03-15 14:10 ` Peter Korsgaard
2023-02-28 22:07 ` [Buildroot] [PATCH 3/3] package/proftpd: needs dynamic library Fabrice Fontaine
2023-03-05 18:36 ` Peter Korsgaard
2023-03-15 14:10 ` Peter Korsgaard
2023-03-05 18:36 ` [Buildroot] [PATCH 1/3] package/proftpd: add libidn2 optional dependency Peter Korsgaard
2023-03-15 14:09 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.