All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part()
Date: Sun, 08 May 2022 10:37:45 +0100	[thread overview]
Message-ID: <87k0aw74ba.wl-maz@kernel.org> (raw)
In-Reply-To: <20220507033506.248310-1-yangyingliang@huawei.com>

On Sat, 07 May 2022 04:35:06 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
> 
> If kcalloc() fails, refcount of 'parts_node' should be decreased.
> 
> Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/irqchip/irq-gic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index b252d5534547..27a35aec2e48 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -1865,7 +1865,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
>  
>  	gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
>  	if (!gic_data.ppi_descs)
> -		return;
> +		goto out_put_node;
>  
>  	nr_parts = of_get_child_count(parts_node);
>  

If you are concerned about this, then why not also address the memory
leak that occur on the same path?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part()
Date: Sun, 08 May 2022 10:37:45 +0100	[thread overview]
Message-ID: <87k0aw74ba.wl-maz@kernel.org> (raw)
In-Reply-To: <20220507033506.248310-1-yangyingliang@huawei.com>

On Sat, 07 May 2022 04:35:06 +0100,
Yang Yingliang <yangyingliang@huawei.com> wrote:
> 
> If kcalloc() fails, refcount of 'parts_node' should be decreased.
> 
> Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/irqchip/irq-gic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index b252d5534547..27a35aec2e48 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -1865,7 +1865,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
>  
>  	gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL);
>  	if (!gic_data.ppi_descs)
> -		return;
> +		goto out_put_node;
>  
>  	nr_parts = of_get_child_count(parts_node);
>  

If you are concerned about this, then why not also address the memory
leak that occur on the same path?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2022-05-08  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07  3:35 [PATCH] irqchip/gic-v3: fix missing of_node_put() in gic_populate_ppi_part() Yang Yingliang
2022-05-07  3:35 ` Yang Yingliang
2022-05-08  9:37 ` Marc Zyngier [this message]
2022-05-08  9:37   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0aw74ba.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.