From: Andreas Schwab <schwab@linux-m68k.org>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-riscv@lists.infradead.org
Subject: Re: [RFC PATCH 1/3] riscv: Correctly print supported extensions
Date: Mon, 22 Nov 2021 13:35:00 +0100 [thread overview]
Message-ID: <87k0h0pdvv.fsf@igel.home> (raw)
In-Reply-To: <2d536b65-e6fd-873f-ed34-4aab7cca4771@irq.a4lg.com> (Tsukasa OI's message of "Sat, 20 Nov 2021 17:53:50 +0900")
On Nov 20 2021, Tsukasa OI wrote:
> This commit replaces BITS_PER_LONG with magic number 26.
>
> Current ISA pretty-printing code expects extension 'a' (bit 0) through
> 'z' (bit 25). Although bit 26 and higher is not currently used (thus never
> cause an issue in practice), it will be an annoying problem if we start to
> use those in the future.
Perhaps replace 26 by 'z' - 'a' + 1?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-11-22 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 8:53 [RFC PATCH 1/3] riscv: Correctly print supported extensions Tsukasa OI
2021-11-22 12:14 ` Ben Dooks
2021-11-23 1:32 ` Tsukasa OI
2021-11-22 12:35 ` Andreas Schwab [this message]
2021-11-23 1:25 ` Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0h0pdvv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.