From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Check GuC status before freq boost
Date: Fri, 12 Nov 2021 08:05:35 -0800 [thread overview]
Message-ID: <87k0hdcqb4.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211112071016.9640-1-vinay.belgaumkar@intel.com>
On Thu, 11 Nov 2021 23:10:16 -0800, Vinay Belgaumkar wrote:
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 4e1d3cd29164..22c1c12369f2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -183,11 +183,15 @@ static int slpc_unset_param(struct intel_guc_slpc *slpc,
> static int slpc_force_min_freq(struct intel_guc_slpc *slpc, u32 freq)
> {
> struct drm_i915_private *i915 = slpc_to_i915(slpc);
> + struct intel_guc *guc = slpc_to_guc(slpc);
> intel_wakeref_t wakeref;
> int ret = 0;
>
> lockdep_assert_held(&slpc->lock);
>
> + if (!intel_guc_is_ready(guc))
> + return -ENODEV;
> +
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
The test wedges/resets the GPU after a request is queued but before it is
retired.
WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc/slpc: Check GuC status before freq boost
Date: Fri, 12 Nov 2021 08:05:35 -0800 [thread overview]
Message-ID: <87k0hdcqb4.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211112071016.9640-1-vinay.belgaumkar@intel.com>
On Thu, 11 Nov 2021 23:10:16 -0800, Vinay Belgaumkar wrote:
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 4e1d3cd29164..22c1c12369f2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -183,11 +183,15 @@ static int slpc_unset_param(struct intel_guc_slpc *slpc,
> static int slpc_force_min_freq(struct intel_guc_slpc *slpc, u32 freq)
> {
> struct drm_i915_private *i915 = slpc_to_i915(slpc);
> + struct intel_guc *guc = slpc_to_guc(slpc);
> intel_wakeref_t wakeref;
> int ret = 0;
>
> lockdep_assert_held(&slpc->lock);
>
> + if (!intel_guc_is_ready(guc))
> + return -ENODEV;
> +
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
The test wedges/resets the GPU after a request is queued but before it is
retired.
next prev parent reply other threads:[~2021-11-12 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 7:10 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Check GuC status before freq boost Vinay Belgaumkar
2021-11-12 7:10 ` Vinay Belgaumkar
2021-11-12 7:24 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-11-12 7:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-12 13:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-12 16:05 ` Dixit, Ashutosh [this message]
2021-11-12 16:05 ` [PATCH] " Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0hdcqb4.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.