All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Marcin Wojtas <mw@semihalf.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: andrew@lunn.ch, robh+dt@kernel.org, Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
Date: Thu, 17 Jun 2021 15:14:18 +0200	[thread overview]
Message-ID: <87k0ms1vmd.fsf@BL-laptop> (raw)
In-Reply-To: <20210322003915.3199775-1-mw@semihalf.com>

Hi Marcin,

> A recent switch to a dedicated AP807 compatible string for the Xenon
> SD/MMC controller result in the driver not being probed when
> using updated device tree with the older kernel revisions.
> It may also be problematic for other OSs/firmware that use
> Linux device tree sources as a reference. Resolve the problem
> with backward compatibility by restoring a previous compatible
> string as secondary one.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> index d9bbbfa4b4eb..4a23f65d475f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> @@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
>  };
>  
>  &ap_sdhci0 {
> -	compatible = "marvell,armada-ap807-sdhci";
> +	compatible = "marvell,armada-ap807-sdhci",
> +		     "marvell,armada-ap806-sdhci"; /* Backward compatibility */
>  };
>  
> -- 
> 2.29.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Marcin Wojtas <mw@semihalf.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: andrew@lunn.ch, robh+dt@kernel.org, Marcin Wojtas <mw@semihalf.com>
Subject: Re: [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon
Date: Thu, 17 Jun 2021 15:14:18 +0200	[thread overview]
Message-ID: <87k0ms1vmd.fsf@BL-laptop> (raw)
In-Reply-To: <20210322003915.3199775-1-mw@semihalf.com>

Hi Marcin,

> A recent switch to a dedicated AP807 compatible string for the Xenon
> SD/MMC controller result in the driver not being probed when
> using updated device tree with the older kernel revisions.
> It may also be problematic for other OSs/firmware that use
> Linux device tree sources as a reference. Resolve the problem
> with backward compatibility by restoring a previous compatible
> string as secondary one.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Applied on mvebu/dt64

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> index d9bbbfa4b4eb..4a23f65d475f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi
> @@ -29,6 +29,7 @@ cpu_clk: clock-cpu {
>  };
>  
>  &ap_sdhci0 {
> -	compatible = "marvell,armada-ap807-sdhci";
> +	compatible = "marvell,armada-ap807-sdhci",
> +		     "marvell,armada-ap806-sdhci"; /* Backward compatibility */
>  };
>  
> -- 
> 2.29.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

  parent reply	other threads:[~2021-06-17 13:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  0:39 [PATCH] arm64: dts: ensure backward compatibility of the AP807 Xenon Marcin Wojtas
2021-03-22  0:39 ` Marcin Wojtas
2021-03-22 12:14 ` Andrew Lunn
2021-03-22 12:14   ` Andrew Lunn
2021-05-12 15:50   ` Marcin Wojtas
2021-05-12 15:50     ` Marcin Wojtas
2021-06-16 19:12     ` Marcin Wojtas
2021-06-16 19:12       ` Marcin Wojtas
2021-06-17 13:14 ` Gregory CLEMENT [this message]
2021-06-17 13:14   ` Gregory CLEMENT
2021-06-17 13:49   ` Marcin Wojtas
2021-06-17 13:49     ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0ms1vmd.fsf@BL-laptop \
    --to=gregory.clement@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mw@semihalf.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.