All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: NVME using PCI legacy interrupts only
Date: Thu, 10 Jun 2021 09:06:19 +0100	[thread overview]
Message-ID: <87k0n2qh38.wl-maz@kernel.org> (raw)
In-Reply-To: <52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com>

On Wed, 09 Jun 2021 19:43:57 +0100,
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> 
> I found that on linux-next from June 8th my nvme disk is using legacy
> interrupts only. Some debugging lead me to irq_find_mapping() in
> msi_domain_alloc() returning -EEXIST.
> 
> The nvme core first allocates a MSI-X interrupt for setup purposes
> and later frees it and allocates the final number of MSI-X interrupts.
> 
> The following experimental change brought back the MSI-X interrupts.
> This makes me think that somehow freeing a MSI-X interrupt doesn't
> free it completely. I didn't see this behavior a few days ago,
> therefore I think it's related to the recent changes to
> irqdomain/genirq.
> 
> Didn't do a bisect yet, maybe you have an idea already.

Yeah, recent changes in the irqdomain subsystem seem to have uncovered
a long standing issue where we are leaving dangling references in some
domains....

I've now dropped the branch from -next while I figure it out.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: NVME using PCI legacy interrupts only
Date: Thu, 10 Jun 2021 09:06:19 +0100	[thread overview]
Message-ID: <87k0n2qh38.wl-maz@kernel.org> (raw)
In-Reply-To: <52371274-20bc-a150-a3ed-ba3e1305ad3e@gmail.com>

On Wed, 09 Jun 2021 19:43:57 +0100,
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> 
> I found that on linux-next from June 8th my nvme disk is using legacy
> interrupts only. Some debugging lead me to irq_find_mapping() in
> msi_domain_alloc() returning -EEXIST.
> 
> The nvme core first allocates a MSI-X interrupt for setup purposes
> and later frees it and allocates the final number of MSI-X interrupts.
> 
> The following experimental change brought back the MSI-X interrupts.
> This makes me think that somehow freeing a MSI-X interrupt doesn't
> free it completely. I didn't see this behavior a few days ago,
> therefore I think it's related to the recent changes to
> irqdomain/genirq.
> 
> Didn't do a bisect yet, maybe you have an idea already.

Yeah, recent changes in the irqdomain subsystem seem to have uncovered
a long standing issue where we are leaving dangling references in some
domains....

I've now dropped the branch from -next while I figure it out.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2021-06-10  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 18:43 linux-next: NVME using PCI legacy interrupts only Heiner Kallweit
2021-06-09 18:43 ` Heiner Kallweit
2021-06-10  8:06 ` Marc Zyngier [this message]
2021-06-10  8:06   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0n2qh38.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=hch@lst.de \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.