From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-ppc <qemu-ppc@nongnu.org>
Subject: Re: [PATCH v2 1/3] hw/block/nand: Register machine reset handler
Date: Wed, 05 May 2021 09:18:16 +0200 [thread overview]
Message-ID: <87k0odvebr.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA_pCcM70-OMaPhaAiW=-V5OK6KbBWSEK8y6AVNxpAtyMA@mail.gmail.com> (Peter Maydell's message of "Sun, 2 May 2021 21:38:59 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Sun, 2 May 2021 at 21:31, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> The TYPE_NAND device is bus-less, thus isn't reset automatically.
>> Register a reset handler to get reset with the machine.
>>
>> Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus")
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>
> Personally I would just revert 7426aa72c36 rather than introduce
> a new use of qemu_register_reset()...
I think this depends on what you dislike more, qemu_register_reset() or
sysbus. Neither is deprecated, both have more than a hundred users.
One more user doesn't matter all that much for either.
I happen to dislike sysbus more, but my opinion on this is yet another
thin that doesn't matter all that much :)
next prev parent reply other threads:[~2021-05-05 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 20:31 [PATCH v2 0/3] hw: Fix reset of bus-less devices Philippe Mathieu-Daudé
2021-05-02 20:31 ` [PATCH v2 1/3] hw/block/nand: Register machine reset handler Philippe Mathieu-Daudé
2021-05-02 20:38 ` Peter Maydell
2021-05-05 7:18 ` Markus Armbruster [this message]
2021-05-02 20:31 ` [PATCH v2 2/3] hw/pci-host/raven: Manually reset the OR_IRQ device Philippe Mathieu-Daudé
2021-05-02 20:45 ` Peter Maydell
2021-05-03 10:05 ` Philippe Mathieu-Daudé
2021-05-03 0:18 ` David Gibson
2021-05-02 20:31 ` [PATCH v2 3/3] hw/arm/armsse: Manually reset the OR_IRQ devices Philippe Mathieu-Daudé
2021-05-02 20:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0odvebr.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.