From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: use spinlock_t instead of struct spinlock
Date: Wed, 19 Feb 2020 15:14:55 +0200 [thread overview]
Message-ID: <87k14ivhv4.fsf@intel.com> (raw)
In-Reply-To: <8736b85ocs.fsf@intel.com>
On Tue, 18 Feb 2020, Jani Nikula <jani.nikula@intel.com> wrote:
> On Mon, 17 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> Quoting Jani Nikula (2020-02-17 18:42:19)
>>> spinlock_t is one case where the typedef is to be preferred over struct
>>> spinlock.
>>>
>>> Fixes: 42fb60de3129 ("drm/i915/gem: Don't leak non-persistent requests on changing engines")
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> If you say so,
>
> Checkpatch and a git grep popularity contest in the kernel tree say
> so...
>
>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Thanks!
And pushed.
BR,
Jani.
>
>> If you look you might find a few more I've added ;)
>
> Oh? My git grep fails me then.
>
> BR,
> Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-19 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 18:42 [Intel-gfx] [PATCH] drm/i915/gem: use spinlock_t instead of struct spinlock Jani Nikula
2020-02-17 18:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-17 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-17 20:26 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-18 7:46 ` Jani Nikula
2020-02-19 13:14 ` Jani Nikula [this message]
2020-02-19 12:02 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k14ivhv4.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.