* [Intel-gfx] [PATCH] drm/i915: Flush context free work on cleanup
@ 2019-11-12 9:06 ` Chris Wilson
0 siblings, 0 replies; 16+ messages in thread
From: Chris Wilson @ 2019-11-12 9:06 UTC (permalink / raw)
To: intel-gfx
Throw in a flush_work() and rcu_barrier() to specifically flush the
context cleanup work.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 72d389afa28a..17f395672e5e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
{
destroy_kernel_context(&i915->kernel_context);
+ flush_work(&i915->gem.contexts.free_work);
}
static int context_idr_cleanup(int id, void *p, void *data)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index b9613d044393..1f68700a2311 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
@@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt)
gt->engine[id] = NULL;
gt->i915->engine[id] = NULL;
}
+ rcu_barrier();
}
/**
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Flush context free work on cleanup
@ 2019-11-12 10:15 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-12 10:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Flush context free work on cleanup
URL : https://patchwork.freedesktop.org/series/69339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7312 -> Patchwork_15228
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/index.html
Known issues
------------
Here are the changes found in Patchwork_15228 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-icl-u4: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@basic-flip-pipe-b:
- fi-skl-6770hq: [PASS][3] -> [DMESG-WARN][4] ([fdo#105541])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-u2: [PASS][5] -> [FAIL][6] ([fdo#109635 ] / [fdo#110387])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][7] ([fdo# 111542]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_flip@basic-flip-vs-wf_vblank:
- fi-skl-6770hq: [DMESG-WARN][9] ([fdo#105541]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-wf_vblank.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-wf_vblank.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7312 -> Patchwork_15228
CI-20190529: 20190529
CI_DRM_7312: d65e3ce77f11e7a925630fa2d65207afaaec7011 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5272: 5997df31db10f190fe8b70d920b6a6b8d3b24126 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15228: 9c6c2f074d44780aab7a65d392ee088337a55e6f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9c6c2f074d44 drm/i915: Flush context free work on cleanup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/i915: Flush context free work on cleanup
@ 2019-11-12 13:55 ` Tvrtko Ursulin
0 siblings, 0 replies; 16+ messages in thread
From: Tvrtko Ursulin @ 2019-11-12 13:55 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 12/11/2019 09:06, Chris Wilson wrote:
> Throw in a flush_work() and rcu_barrier() to specifically flush the
> context cleanup work.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
? Might have gotten it wrong.. only did a quick dig.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 72d389afa28a..17f395672e5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> {
> destroy_kernel_context(&i915->kernel_context);
> + flush_work(&i915->gem.contexts.free_work);
> }
>
> static int context_idr_cleanup(int id, void *p, void *data)
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index b9613d044393..1f68700a2311 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt)
> gt->engine[id] = NULL;
> gt->i915->engine[id] = NULL;
> }
> + rcu_barrier();
Why this?
> }
>
> /**
>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Flush context free work on cleanup
@ 2019-11-12 13:55 ` Tvrtko Ursulin
0 siblings, 0 replies; 16+ messages in thread
From: Tvrtko Ursulin @ 2019-11-12 13:55 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 12/11/2019 09:06, Chris Wilson wrote:
> Throw in a flush_work() and rcu_barrier() to specifically flush the
> context cleanup work.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
? Might have gotten it wrong.. only did a quick dig.
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 72d389afa28a..17f395672e5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> {
> destroy_kernel_context(&i915->kernel_context);
> + flush_work(&i915->gem.contexts.free_work);
> }
>
> static int context_idr_cleanup(int id, void *p, void *data)
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index b9613d044393..1f68700a2311 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt)
> gt->engine[id] = NULL;
> gt->i915->engine[id] = NULL;
> }
> + rcu_barrier();
Why this?
> }
>
> /**
>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] drm/i915: Flush context free work on cleanup
@ 2019-11-12 14:04 ` Chris Wilson
0 siblings, 0 replies; 16+ messages in thread
From: Chris Wilson @ 2019-11-12 14:04 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Quoting Tvrtko Ursulin (2019-11-12 13:55:35)
>
> On 12/11/2019 09:06, Chris Wilson wrote:
> > Throw in a flush_work() and rcu_barrier() to specifically flush the
> > context cleanup work.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
>
> ? Might have gotten it wrong.. only did a quick dig.
Seems reasonable, I was thinking without an explicit flush we are at the
mercy of the flush_workqueue(), hence why we have so many! :) But yes,
the switch from i915->wq to system_wq does mean a new requirement for
the global flush whose name escapes me right now.
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index 72d389afa28a..17f395672e5e 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> > void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> > {
> > destroy_kernel_context(&i915->kernel_context);
> > + flush_work(&i915->gem.contexts.free_work);
> > }
> >
> > static int context_idr_cleanup(int id, void *p, void *data)
> > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > index b9613d044393..1f68700a2311 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt)
> > gt->engine[id] = NULL;
> > gt->i915->engine[id] = NULL;
> > }
> > + rcu_barrier();
>
> Why this?
It's so we play catch up the RCU free_work of the ppgtt that we trigger
here and we need to be confident has been queued before we do its fini.
I was acting on a memory of a similar debugobject splat, quite possibly
over-reacting.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Flush context free work on cleanup
@ 2019-11-12 14:04 ` Chris Wilson
0 siblings, 0 replies; 16+ messages in thread
From: Chris Wilson @ 2019-11-12 14:04 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
Quoting Tvrtko Ursulin (2019-11-12 13:55:35)
>
> On 12/11/2019 09:06, Chris Wilson wrote:
> > Throw in a flush_work() and rcu_barrier() to specifically flush the
> > context cleanup work.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
>
> ? Might have gotten it wrong.. only did a quick dig.
Seems reasonable, I was thinking without an explicit flush we are at the
mercy of the flush_workqueue(), hence why we have so many! :) But yes,
the switch from i915->wq to system_wq does mean a new requirement for
the global flush whose name escapes me right now.
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > index 72d389afa28a..17f395672e5e 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> > @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> > void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> > {
> > destroy_kernel_context(&i915->kernel_context);
> > + flush_work(&i915->gem.contexts.free_work);
> > }
> >
> > static int context_idr_cleanup(int id, void *p, void *data)
> > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > index b9613d044393..1f68700a2311 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> > @@ -402,6 +402,7 @@ void intel_engines_cleanup(struct intel_gt *gt)
> > gt->engine[id] = NULL;
> > gt->i915->engine[id] = NULL;
> > }
> > + rcu_barrier();
>
> Why this?
It's so we play catch up the RCU free_work of the ppgtt that we trigger
here and we need to be confident has been queued before we do its fini.
I was acting on a memory of a similar debugobject splat, quite possibly
over-reacting.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Flush context free work on cleanup
@ 2019-11-12 14:36 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-12 14:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Flush context free work on cleanup
URL : https://patchwork.freedesktop.org/series/69339/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7312_full -> Patchwork_15228_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15228_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15228_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15228_full:
### IGT changes ###
#### Possible regressions ####
* igt@prime_self_import@basic-llseek-size:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb7/igt@prime_self_import@basic-llseek-size.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb9/igt@prime_self_import@basic-llseek-size.html
Known issues
------------
Here are the changes found in Patchwork_15228_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb7/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110841])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb8/igt@gem_exec_async@concurrent-writes-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_schedule@independent-bsd1:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb4/igt@gem_exec_schedule@independent-bsd1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb3/igt@gem_exec_schedule@independent-bsd1.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#112037])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_sync@basic-each:
- shard-tglb: [PASS][13] -> [INCOMPLETE][14] ([fdo#111647] / [fdo#111998])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb1/igt@gem_sync@basic-each.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb6/igt@gem_sync@basic-each.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-hsw5/igt@gem_userptr_blits@sync-unmap-after-close.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-hsw6/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108566]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111832] / [fdo#111850]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb2/igt@i915_pm_backlight@fade_with_suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb7/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#111795 ])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb5/igt@i915_pm_dc@dc5-dpms.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#111830 ])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-apl1/igt@i915_suspend@forcewake.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-apl6/igt@i915_suspend@forcewake.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([fdo#103313])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][33] -> [INCOMPLETE][34] ([fdo#111832] / [fdo#111850] / [fdo#111884]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [fdo#110403])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][37] -> [FAIL][38] ([fdo#103166])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][41] -> [FAIL][42] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-apl3/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-apl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111850])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb9/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +7 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb1/igt@perf_pmu@busy-vcs1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb6/igt@perf_pmu@busy-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-tglb: [INCOMPLETE][47] ([fdo#111832]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb3/igt@gem_ctx_isolation@vcs0-s3.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb1/igt@gem_ctx_isolation@vcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb7/igt@gem_ctx_isolation@vcs1-none.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][51] ([fdo#112080]) -> [PASS][52] +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][53] ([fdo#109276]) -> [PASS][54] +11 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb3/igt@gem_exec_schedule@independent-bsd2.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][55] ([fdo#112146]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_mmap_gtt@hang:
- shard-tglb: [INCOMPLETE][57] ([fdo#111998]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb6/igt@gem_mmap_gtt@hang.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb7/igt@gem_mmap_gtt@hang.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [FAIL][59] ([fdo#112037]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-hsw7/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][61] ([fdo#108566]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-apl4/igt@gem_softpin@noreloc-s3.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-apl2/igt@gem_softpin@noreloc-s3.html
* igt@gem_sync@basic-store-each:
- shard-tglb: [INCOMPLETE][63] ([fdo#111647] / [fdo#111747]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb4/igt@gem_sync@basic-store-each.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb5/igt@gem_sync@basic-store-each.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][65] ([fdo#111870]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-hsw7/igt@gem_userptr_blits@sync-unmap-cycles.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-hsw7/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][67] ([fdo#111830 ]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][69] ([fdo#104108] / [fdo#107807]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl8/igt@i915_pm_rpm@system-suspend-modeset.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl8/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_pm_rpm@universal-planes:
- shard-hsw: [INCOMPLETE][71] ([fdo#103540] / [fdo#107807]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-hsw1/igt@i915_pm_rpm@universal-planes.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-hsw7/igt@i915_pm_rpm@universal-planes.html
* igt@i915_suspend@debugfs-reader:
- shard-skl: [INCOMPLETE][73] ([fdo#104108]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl6/igt@i915_suspend@debugfs-reader.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl6/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- shard-skl: [FAIL][75] ([fdo#103232]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][77] ([fdo#108566]) -> [PASS][78] +7 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [FAIL][79] ([fdo#103355]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][81] ([fdo#105363]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [INCOMPLETE][83] ([fdo#109507]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl6/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglb: [FAIL][85] ([fdo#103167]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [FAIL][87] ([fdo#103167]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [INCOMPLETE][89] ([fdo#111832] / [fdo#111850]) -> [PASS][90] +7 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes:
- shard-tglb: [INCOMPLETE][91] ([fdo#111850]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][93] ([fdo#108145]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][95] ([fdo#109441]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][97] ([fdo#109276] / [fdo#112080]) -> [FAIL][98] ([fdo#111329]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb7/igt@gem_ctx_isolation@vcs1-nonpriv.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_exec_schedule@deep-render:
- shard-tglb: [INCOMPLETE][99] ([fdo#111671]) -> [FAIL][100] ([fdo#111646])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-tglb3/igt@gem_exec_schedule@deep-render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-tglb1/igt@gem_exec_schedule@deep-render.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][101] ([fdo#111330]) -> [SKIP][102] ([fdo#109276]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7312/shard-iclb1/igt@gem_mocs_settings@mocs-reset-bsd2.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#10
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15228/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v2] drm/i915: Flush context free work on cleanup
@ 2019-11-12 15:00 ` Chris Wilson
0 siblings, 0 replies; 16+ messages in thread
From: Chris Wilson @ 2019-11-12 15:00 UTC (permalink / raw)
To: intel-gfx
Throw in a flush_work() to specifically flush the context cleanup work
before the module is unloaded.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 72d389afa28a..17f395672e5e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
{
destroy_kernel_context(&i915->kernel_context);
+ flush_work(&i915->gem.contexts.free_work);
}
static int context_idr_cleanup(int id, void *p, void *data)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Intel-gfx] [PATCH v2] drm/i915: Flush context free work on cleanup
@ 2019-11-12 15:00 ` Chris Wilson
0 siblings, 0 replies; 16+ messages in thread
From: Chris Wilson @ 2019-11-12 15:00 UTC (permalink / raw)
To: intel-gfx
Throw in a flush_work() to specifically flush the context cleanup work
before the module is unloaded.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 72d389afa28a..17f395672e5e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
{
destroy_kernel_context(&i915->kernel_context);
+ flush_work(&i915->gem.contexts.free_work);
}
static int context_idr_cleanup(int id, void *p, void *data)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2] drm/i915: Flush context free work on cleanup
@ 2019-11-12 16:01 ` Mika Kuoppala
0 siblings, 0 replies; 16+ messages in thread
From: Mika Kuoppala @ 2019-11-12 16:01 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Throw in a flush_work() to specifically flush the context cleanup work
> before the module is unloaded.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 72d389afa28a..17f395672e5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> {
> destroy_kernel_context(&i915->kernel_context);
> + flush_work(&i915->gem.contexts.free_work);
> }
>
> static int context_idr_cleanup(int id, void *p, void *data)
> --
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [Intel-gfx] [PATCH v2] drm/i915: Flush context free work on cleanup
@ 2019-11-12 16:01 ` Mika Kuoppala
0 siblings, 0 replies; 16+ messages in thread
From: Mika Kuoppala @ 2019-11-12 16:01 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Throw in a flush_work() to specifically flush the context cleanup work
> before the module is unloaded.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112248
> Fixes: a4e7ccdac38e ("drm/i915: Move context management under GEM")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 72d389afa28a..17f395672e5e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -776,6 +776,7 @@ int i915_gem_init_contexts(struct drm_i915_private *i915)
> void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
> {
> destroy_kernel_context(&i915->kernel_context);
> + flush_work(&i915->gem.contexts.free_work);
> }
>
> static int context_idr_cleanup(int id, void *p, void *data)
> --
> 2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Flush context free work on cleanup (rev2)
@ 2019-11-12 20:03 ` Patchwork
0 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2019-11-12 20:03 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Flush context free work on cleanup (rev2)
URL : https://patchwork.freedesktop.org/series/69339/
State : failure
== Summary ==
Applying: drm/i915: Flush context free work on cleanup
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gem/i915_gem_context.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread