From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Trim ring measurement by one
Date: Mon, 12 Aug 2019 17:25:14 +0300 [thread overview]
Message-ID: <87k1bi796d.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <156561617536.2301.12360130942873835783@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-08-12 12:52:56)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Be a little more conservative in our ring measurement and exclude one
>> > batch to leave room in case our user needs to wrap (where a request will
>> > be expanded to cover the unused space at the end of the ring).
>> >
>>
>> did read the wrapping part and that seems to be the case that
>> we enlarge the wrapping request.
>>
>> However do we lose some coverage on the actual wrap tests?
>
> The tests where we call measure_ring_size, are those that we do not want
> to block due to running out of space (and wrapping) :)
Ok. The bugs on the wrap itself should bubble to surface
indirectly. Agreed that estimating the inflight wrong
is bad.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/i915: Trim ring measurement by one
Date: Mon, 12 Aug 2019 17:25:14 +0300 [thread overview]
Message-ID: <87k1bi796d.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <156561617536.2301.12360130942873835783@skylake-alporthouse-com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2019-08-12 12:52:56)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Be a little more conservative in our ring measurement and exclude one
>> > batch to leave room in case our user needs to wrap (where a request will
>> > be expanded to cover the unused space at the end of the ring).
>> >
>>
>> did read the wrapping part and that seems to be the case that
>> we enlarge the wrapping request.
>>
>> However do we lose some coverage on the actual wrap tests?
>
> The tests where we call measure_ring_size, are those that we do not want
> to block due to running out of space (and wrapping) :)
Ok. The bugs on the wrap itself should bubble to surface
indirectly. Agreed that estimating the inflight wrong
is bad.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-12 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 10:32 [igt-dev] [PATCH i-g-t] lib/i915: Trim ring measurement by one Chris Wilson
2019-08-12 10:32 ` Chris Wilson
2019-08-12 11:11 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-12 11:52 ` [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2019-08-12 11:52 ` Mika Kuoppala
2019-08-12 13:12 ` [igt-dev] " Chris Wilson
2019-08-12 13:12 ` Chris Wilson
2019-08-12 13:22 ` [igt-dev] " Chris Wilson
2019-08-12 13:22 ` Chris Wilson
2019-08-12 14:25 ` Mika Kuoppala [this message]
2019-08-12 14:25 ` Mika Kuoppala
2019-08-12 15:11 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1bi796d.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.