From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert \(git\)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kraxel@redhat.com,
mst@redhat.com, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] wavcapture: Convert to error_report
Date: Thu, 14 Feb 2019 11:01:15 +0100 [thread overview]
Message-ID: <87k1i2aduc.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190212134758.10514-5-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 12 Feb 2019 13:47:58 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Kill off a pile of monitor_printf's and cur_mon usage.
You also switch from the two line error format
<error message>
Reason: <strerror(errno)>
to the more common
<error message>: <strerror(errno)>
Suggest to mention that you're changing error messages in the commit
message.
> The only one left in wavcapture.c is the info case.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kraxel@redhat.com,
mst@redhat.com, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] wavcapture: Convert to error_report
Date: Thu, 14 Feb 2019 11:01:15 +0100 [thread overview]
Message-ID: <87k1i2aduc.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190212134758.10514-5-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 12 Feb 2019 13:47:58 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Kill off a pile of monitor_printf's and cur_mon usage.
You also switch from the two line error format
<error message>
Reason: <strerror(errno)>
to the more common
<error message>: <strerror(errno)>
Suggest to mention that you're changing error messages in the commit
message.
> The only one left in wavcapture.c is the info case.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2019-02-14 10:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 13:47 [Qemu-trivial] [PATCH 0/4] a few trivials Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-trivial] [PATCH 1/4] pckbd: Convert DPRINTF->trace Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2019-02-12 14:10 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-12 14:10 ` Philippe Mathieu-Daudé
2019-02-14 9:54 ` [Qemu-trivial] " Laurent Vivier
2019-02-14 9:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-02-12 13:47 ` [Qemu-trivial] [PATCH 2/4] HMP: Prepend errors with 'Error:' Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2019-02-12 14:11 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-12 14:11 ` Philippe Mathieu-Daudé
2019-02-14 9:53 ` [Qemu-trivial] " Markus Armbruster
2019-02-14 9:53 ` Markus Armbruster
2019-02-14 9:55 ` [Qemu-trivial] " Laurent Vivier
2019-02-14 9:55 ` [Qemu-devel] " Laurent Vivier
2019-02-12 13:47 ` [Qemu-trivial] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2019-02-12 14:12 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2019-02-12 14:12 ` Philippe Mathieu-Daudé
2019-02-12 14:41 ` [Qemu-trivial] " Cornelia Huck
2019-02-12 14:41 ` Cornelia Huck
2019-02-12 13:47 ` [Qemu-trivial] [PATCH 4/4] wavcapture: Convert to error_report Dr. David Alan Gilbert (git)
2019-02-12 13:47 ` [Qemu-devel] " Dr. David Alan Gilbert (git)
2019-02-14 9:58 ` [Qemu-trivial] " Laurent Vivier
2019-02-14 9:58 ` [Qemu-devel] " Laurent Vivier
2019-02-14 10:01 ` Markus Armbruster [this message]
2019-02-14 10:01 ` [Qemu-devel] " Markus Armbruster
2019-02-12 14:05 ` [Qemu-trivial] [PATCH 0/4] a few trivials Michael S. Tsirkin
2019-02-12 14:05 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1i2aduc.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.