All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
Date: Wed, 08 Aug 2018 12:14:42 +0300	[thread overview]
Message-ID: <87k1p143ul.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180808084924.17826-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> A simple question as to whether the error only occurs on rcs/hsw, or all.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_eio.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 9d608e83e..45f9f9c2d 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
>  	close(fd);
>  }
>  
> -/*
> - * Verify that we can submit and execute work after unwedging the GPU.
> - */
> -static void test_reset_stress(int fd, unsigned int flags)
> +static void reset_stress(int fd,
> +			 uint32_t ctx0, unsigned int engine,
> +			 unsigned int flags)
>  {
> -	uint32_t ctx0 = context_create_safe(fd);
> -
>  	igt_until_timeout(5) {
>  		struct drm_i915_gem_execbuffer2 execbuf = { };
>  		struct drm_i915_gem_exec_object2 obj = { };
> @@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		execbuf.buffers_ptr = to_user_pointer(&obj);
>  		execbuf.buffer_count = 1;
>  		execbuf.rsvd1 = ctx0;
> +		execbuf.flags = engine;
>  
>  		for (i = 0; i < 10; i++)
>  			gem_execbuf(fd, &execbuf);
> @@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		gem_context_destroy(fd, ctx);
>  		gem_close(fd, obj.handle);
>  	}
> +}
> +
> +/*
> + * Verify that we can submit and execute work after unwedging the GPU.
> + */
> +static void test_reset_stress(int fd, unsigned int flags)
> +{
> +	uint32_t ctx0 = context_create_safe(fd);
> +	unsigned int engine;
> +
> +	for_each_engine(fd, engine)
> +		reset_stress(fd, ctx0, engine, flags);
>  
>  	gem_context_destroy(fd, ctx0);
>  }
> -- 
> 2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
Date: Wed, 08 Aug 2018 12:14:42 +0300	[thread overview]
Message-ID: <87k1p143ul.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180808084924.17826-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> A simple question as to whether the error only occurs on rcs/hsw, or all.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_eio.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 9d608e83e..45f9f9c2d 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
>  	close(fd);
>  }
>  
> -/*
> - * Verify that we can submit and execute work after unwedging the GPU.
> - */
> -static void test_reset_stress(int fd, unsigned int flags)
> +static void reset_stress(int fd,
> +			 uint32_t ctx0, unsigned int engine,
> +			 unsigned int flags)
>  {
> -	uint32_t ctx0 = context_create_safe(fd);
> -
>  	igt_until_timeout(5) {
>  		struct drm_i915_gem_execbuffer2 execbuf = { };
>  		struct drm_i915_gem_exec_object2 obj = { };
> @@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		execbuf.buffers_ptr = to_user_pointer(&obj);
>  		execbuf.buffer_count = 1;
>  		execbuf.rsvd1 = ctx0;
> +		execbuf.flags = engine;
>  
>  		for (i = 0; i < 10; i++)
>  			gem_execbuf(fd, &execbuf);
> @@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		gem_context_destroy(fd, ctx);
>  		gem_close(fd, obj.handle);
>  	}
> +}
> +
> +/*
> + * Verify that we can submit and execute work after unwedging the GPU.
> + */
> +static void test_reset_stress(int fd, unsigned int flags)
> +{
> +	uint32_t ctx0 = context_create_safe(fd);
> +	unsigned int engine;
> +
> +	for_each_engine(fd, engine)
> +		reset_stress(fd, ctx0, engine, flags);
>  
>  	gem_context_destroy(fd, ctx0);
>  }
> -- 
> 2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-08  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  8:49 [igt-dev] [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine Chris Wilson
2018-08-08  8:49 ` Chris Wilson
2018-08-08  9:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-08  9:14 ` Mika Kuoppala [this message]
2018-08-08  9:14   ` [PATCH i-g-t] " Mika Kuoppala
2018-08-08 11:17 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1p143ul.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.