From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uclinux-h8-devel@lists.sourceforge.jp
Subject: Re: [PATCH] arch/h8300: eliminate kgbd.c warning
Date: Sun, 22 Jul 2018 22:33:35 +0900 [thread overview]
Message-ID: <87k1pnfl8w.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <7c458f27-9603-af24-e4e3-b87ef99693e3@infradead.org>
On Fri, 20 Jul 2018 11:36:06 +0900,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drop the "const" qualifier from arch_kgdb_ops to eliminate the gcc
> warning (gcc version is 8.1.0).
>
> arch/h8300/kernel/kgdb.c:132:24: error: conflicting type qualifiers for 'arch_kgdb_ops'
> const struct kgdb_arch arch_kgdb_ops = {
> In file included from ../arch/h8300/kernel/kgdb.c:12:
> ../include/linux/kgdb.h:284:26: note: previous declaration of 'arch_kgdb_ops' was here
> extern struct kgdb_arch arch_kgdb_ops;
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> ---
> arch/h8300/kernel/kgdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180717.orig/arch/h8300/kernel/kgdb.c
> +++ linux-next-20180717/arch/h8300/kernel/kgdb.c
> @@ -129,7 +129,7 @@ void kgdb_arch_exit(void)
> /* Nothing to do */
> }
>
> -const struct kgdb_arch arch_kgdb_ops = {
> +struct kgdb_arch arch_kgdb_ops = {
> /* Breakpoint instruction: trapa #2 */
> .gdb_bpt_instr = { 0x57, 0x20 },
> };
>
>
Applied to h8300-next.
Thanks.
--
Yosinori Sato
prev parent reply other threads:[~2018-07-22 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 2:36 [PATCH] arch/h8300: eliminate kgbd.c warning Randy Dunlap
2018-07-22 13:33 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1pnfl8w.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.