From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 0/5] refactor float-to-float and fix AHP
Date: Thu, 10 May 2018 14:34:35 +0100 [thread overview]
Message-ID: <87k1sbvdlg.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA88-EFYN3y-sU=YbzeT-eXCBk7md-y2rEQfpJtZ+MF-wQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 10 May 2018 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote:
>> Hi,
>>
>> Hi,
>>
>> I've not included the test case in the series but you can find it in
>> my TCG fixup branch:
>>
>> https://github.com/stsquad/qemu/blob/testing/tcg-tests-revival-v4/tests/tcg/arm/fcvt.c
>>
>> Some of the ARMv7 versions are commented out as they where not
>> supported until later revs. I do have a build that includes that but
>> unfortunately the Debian compiler it too old to build it.
>>
>> : patch 0001/fpu softfloat int_to_float ensure r fully initial.patch needs review
>> : patch 0004/target arm convert conversion helpers to fpst ahp.patch needs review
>> : patch 0005/target arm squash FZ16 behaviour for conversions.patch needs review
>
> This still seems to regress the NaN conversion case I mentioned
> in review of the previous series:
>
> (3) Here's a NaN case we get wrong now: 64 to IEEE-16 conversion,
> input is 0x7ff0000000000001 (an SNaN), we produce
> 0x7c00 (infinity) but should produce 0x7e00 (a QNaN).
Hmm I had added the test case but due to another bug it never actually
ran :-/
>
> thanks
> -- PMM
--
Alex Bennée
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 0/5] refactor float-to-float and fix AHP
Date: Thu, 10 May 2018 14:34:35 +0100 [thread overview]
Message-ID: <87k1sbvdlg.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA88-EFYN3y-sU=YbzeT-eXCBk7md-y2rEQfpJtZ+MF-wQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 10 May 2018 at 10:42, Alex Bennée <alex.bennee@linaro.org> wrote:
>> Hi,
>>
>> Hi,
>>
>> I've not included the test case in the series but you can find it in
>> my TCG fixup branch:
>>
>> https://github.com/stsquad/qemu/blob/testing/tcg-tests-revival-v4/tests/tcg/arm/fcvt.c
>>
>> Some of the ARMv7 versions are commented out as they where not
>> supported until later revs. I do have a build that includes that but
>> unfortunately the Debian compiler it too old to build it.
>>
>> : patch 0001/fpu softfloat int_to_float ensure r fully initial.patch needs review
>> : patch 0004/target arm convert conversion helpers to fpst ahp.patch needs review
>> : patch 0005/target arm squash FZ16 behaviour for conversions.patch needs review
>
> This still seems to regress the NaN conversion case I mentioned
> in review of the previous series:
>
> (3) Here's a NaN case we get wrong now: 64 to IEEE-16 conversion,
> input is 0x7ff0000000000001 (an SNaN), we produce
> 0x7c00 (infinity) but should produce 0x7e00 (a QNaN).
Hmm I had added the test case but due to another bug it never actually
ran :-/
>
> thanks
> -- PMM
--
Alex Bennée
next prev parent reply other threads:[~2018-05-10 13:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 9:42 [PATCH v3 0/5] refactor float-to-float and fix AHP Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 9:42 ` [PATCH v3 1/5] fpu/softfloat: int_to_float ensure r fully initialised Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 12:40 ` Peter Maydell
2018-05-10 12:40 ` [Qemu-devel] " Peter Maydell
2018-05-10 14:50 ` Richard Henderson
2018-05-10 14:50 ` [Qemu-devel] " Richard Henderson
2018-05-10 9:42 ` [PATCH v3 2/5] fpu/softfloat: re-factor float to float conversions Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 12:48 ` Peter Maydell
2018-05-10 12:48 ` [Qemu-devel] " Peter Maydell
2018-05-10 13:03 ` Alex Bennée
2018-05-10 13:03 ` [Qemu-devel] " Alex Bennée
2018-05-10 9:42 ` [PATCH v3 3/5] fpu/softfloat: support ARM Alternative half-precision Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 9:42 ` [PATCH v3 4/5] target/arm: convert conversion helpers to fpst/ahp_flag Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 9:42 ` [PATCH v3 5/5] target/arm: squash FZ16 behaviour for conversions Alex Bennée
2018-05-10 9:42 ` [Qemu-devel] " Alex Bennée
2018-05-10 12:55 ` [PATCH v3 0/5] refactor float-to-float and fix AHP Peter Maydell
2018-05-10 12:55 ` [Qemu-devel] " Peter Maydell
2018-05-10 13:34 ` Alex Bennée [this message]
2018-05-10 13:34 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1sbvdlg.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.