From: Jani Nikula <jani.nikula@linux.intel.com>
To: Patchwork <patchwork@emeril.freedesktop.org>,
Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.CHECKPATCH: warning for GMBUS changes (rev3)
Date: Tue, 17 Apr 2018 15:50:29 +0300 [thread overview]
Message-ID: <87k1t6f14a.fsf@intel.com> (raw)
In-Reply-To: <20180417113027.22077.87903@emeril.freedesktop.org>
On Tue, 17 Apr 2018, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: GMBUS changes (rev3)
> URL : https://patchwork.freedesktop.org/series/41632/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 16f60217eb21 drm/i915/gmbus: Increase the Bytes per Rd/Wr Op
> bcedea2a9483 drm/i915/gmbus: Enable burst read
> -:28: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
> #28: FILE: drivers/gpu/drm/i915/i915_drv.h:2554:
> +#define HAS_GMBUS_BURST_READ(dev_priv) (INTEL_GEN(dev_priv) >= 10 || \
> + IS_GEMINILAKE(dev_priv) || \
> + IS_KABYLAKE(dev_priv))
>
> -:42: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> #42: FILE: drivers/gpu/drm/i915/i915_reg.h:2999:
> +#define GMBUS_BYTE_CNT_OVERRIDE (1<<6)
> ^
Both can be ignored.
>
> total: 0 errors, 0 warnings, 2 checks, 59 lines checked
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-17 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 8:55 [PATCH v3 0/2] GMBUS changes Ramalingam C
2018-04-17 8:55 ` [PATCH v3 1/2] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op Ramalingam C
2018-04-17 18:09 ` Ville Syrjälä
2018-04-18 5:21 ` Ramalingam C
2018-04-18 6:20 ` Jani Nikula
2018-04-18 15:17 ` Ville Syrjälä
2018-04-19 4:15 ` Ramalingam C
2018-04-17 8:55 ` [PATCH v3 2/2] drm/i915/gmbus: Enable burst read Ramalingam C
2018-04-17 18:42 ` Ville Syrjälä
2018-04-18 11:18 ` Ramalingam C
2018-04-17 11:30 ` ✗ Fi.CI.CHECKPATCH: warning for GMBUS changes (rev3) Patchwork
2018-04-17 12:50 ` Jani Nikula [this message]
2018-04-17 11:31 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-04-17 11:47 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-17 13:07 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1t6f14a.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=patchwork@emeril.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.