Re: [v4.4.40] patch backport error

[Felipe Balbi <balbi@kernel.org>]

Hi,

Bin Liu <b-liu@ti.com> writes:
> On Wed, Jan 11, 2017 at 07:13:30PM +0200, Felipe Balbi wrote:
>> 
>> hi,
>> 
>> Bin Liu <b-liu@ti.com> writes:
>> > I am unable to figure out what was happening, but there seems to be a
>> > patch backport error in v4.4.40.
>> >
>> > Commit c53af76d5de1 (usb: gadget: composite: always set ep->mult to a
>> > sensible value) is backported from upstream
>> > eaa496ffaaf19591fe471a36cef366146eeb9153, however c53af76d5de1 has
>> >
>> > +               _ep->mult = usb_endpoint_maxp(_ep->desc) & 0x7ff;
>> >
>> > but eaa496ffaaf19591fe471a36cef366146eeb9153 has
>> >
>> > +               _ep->mult = usb_endpoint_maxp_mult(_ep->desc);
>> >
>> > they are not consistant.
>> >
>> > I haven't checked v4.9 yet, not sure if this happens there too.
>> 
>> oh-oh. you're correct, I sent the wrong patch :-(
>
> so you sent a separate set to stable? I thought it was directly back
> ported from upstream which has the correct version?

well, it had to be manually backported to do away with the dependency on
usb_endpoint_maxp_mult(), but I ended up reimplementing
usb_endpoint_maxp() correctly instead of actually extracting high bits
of wMaxPacketSize

-- 
balbi