All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Bin Liu <b-liu@ti.com>, stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: [v4.4.40] patch backport error
Date: Wed, 11 Jan 2017 19:13:30 +0200	[thread overview]
Message-ID: <87pojt5xl1.fsf@linux.intel.com> (raw)
In-Reply-To: <20170111171305.GB18730@uda0271908>


hi,

Bin Liu <b-liu@ti.com> writes:
> I am unable to figure out what was happening, but there seems to be a
> patch backport error in v4.4.40.
>
> Commit c53af76d5de1 (usb: gadget: composite: always set ep->mult to a
> sensible value) is backported from upstream
> eaa496ffaaf19591fe471a36cef366146eeb9153, however c53af76d5de1 has
>
> +               _ep->mult = usb_endpoint_maxp(_ep->desc) & 0x7ff;
>
> but eaa496ffaaf19591fe471a36cef366146eeb9153 has
>
> +               _ep->mult = usb_endpoint_maxp_mult(_ep->desc);
>
> they are not consistant.
>
> I haven't checked v4.9 yet, not sure if this happens there too.

oh-oh. you're correct, I sent the wrong patch :-(

I'll send a correct patch tomorrow. Greg, do you want a revert followed
by correct patch, or just fix-up patch?

-- 
balbi

  reply	other threads:[~2017-01-11 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 17:13 [v4.4.40] patch backport error Bin Liu
2017-01-11 17:13 ` Felipe Balbi [this message]
2017-01-11 17:22   ` Bin Liu
2017-01-11 17:28     ` Felipe Balbi
2017-01-11 20:17   ` Greg Kroah-Hartman
2017-01-12  7:51     ` Greg Kroah-Hartman
2017-01-11 17:27 ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pojt5xl1.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.