All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static
Date: Tue, 07 Jun 2016 16:28:39 +0200	[thread overview]
Message-ID: <87k2i1oyy0.fsf@free-electrons.com> (raw)
In-Reply-To: <1465309073-20584-1-git-send-email-ben.dooks@codethink.co.uk> (Ben Dooks's message of "Tue, 7 Jun 2016 15:17:53 +0100")

Hi Ben,
 
 On mar., juin 07 2016, Ben Dooks <ben.dooks@codethink.co.uk> wrote:

> The driver does not export armada_370_xp_timer_syscore_ops so
> make it static to fix the following warning:
>
> drivers/clocksource/time-armada-370-xp.c:249:20: warning: symbol 'armada_370_xp_timer_syscore_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
>  drivers/clocksource/time-armada-370-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index d93ec3c..601dbf74 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -246,7 +246,7 @@ static void armada_370_xp_timer_resume(void)
>  	writel(timer0_local_ctrl_reg, local_base + TIMER_CTRL_OFF);
>  }
>  
> -struct syscore_ops armada_370_xp_timer_syscore_ops = {
> +static struct syscore_ops armada_370_xp_timer_syscore_ops = {
>  	.suspend	= armada_370_xp_timer_suspend,
>  	.resume		= armada_370_xp_timer_resume,
>  };
> -- 
> 2.8.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static
Date: Tue, 07 Jun 2016 16:28:39 +0200	[thread overview]
Message-ID: <87k2i1oyy0.fsf@free-electrons.com> (raw)
In-Reply-To: <1465309073-20584-1-git-send-email-ben.dooks@codethink.co.uk> (Ben Dooks's message of "Tue, 7 Jun 2016 15:17:53 +0100")

Hi Ben,
 
 On mar., juin 07 2016, Ben Dooks <ben.dooks@codethink.co.uk> wrote:

> The driver does not export armada_370_xp_timer_syscore_ops so
> make it static to fix the following warning:
>
> drivers/clocksource/time-armada-370-xp.c:249:20: warning: symbol 'armada_370_xp_timer_syscore_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


> ---
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/clocksource/time-armada-370-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> index d93ec3c..601dbf74 100644
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -246,7 +246,7 @@ static void armada_370_xp_timer_resume(void)
>  	writel(timer0_local_ctrl_reg, local_base + TIMER_CTRL_OFF);
>  }
>  
> -struct syscore_ops armada_370_xp_timer_syscore_ops = {
> +static struct syscore_ops armada_370_xp_timer_syscore_ops = {
>  	.suspend	= armada_370_xp_timer_suspend,
>  	.resume		= armada_370_xp_timer_resume,
>  };
> -- 
> 2.8.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2016-06-07 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 14:17 [PATCH] clocksource/drivers/armada-370-xp: make syscore_ops static Ben Dooks
2016-06-07 14:17 ` Ben Dooks
2016-06-07 14:28 ` Gregory CLEMENT [this message]
2016-06-07 14:28   ` Gregory CLEMENT
2016-06-16 14:40 ` Daniel Lezcano
2016-06-16 14:40   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2i1oyy0.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.