All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Programmingkid <programmingkidx@gmail.com>,
	qemu-devel qemu-devel <qemu-devel@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] fix missing event_notifier_init_fd() function on Mac OS X
Date: Fri, 08 Apr 2016 13:25:36 +0200	[thread overview]
Message-ID: <87k2k8wde7.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <56FC0102.9060206@redhat.com> (Paolo Bonzini's message of "Wed, 30 Mar 2016 18:38:26 +0200")

[Wasn't delivered correctly by eggs.gnu.org, resending]

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 30/03/2016 18:35, Programmingkid wrote:
>> Remove macro that prevents event_notifier_init_fd() function from being compiled on Mac OS X.
>> 
>> This patch fixes this error:
>> 
>> Undefined symbols for architecture x86_64:
>>   "_event_notifier_init_fd", referenced from:
>>       _process_msg in ivshmem.o
>> ld: symbol(s) not found for architecture x86_64
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [qemu-system-ppc] Error 1
>> make: *** [subdir-ppc-softmmu] Error 2
>> 
>> 
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> This is intentional, this feature of ivshmem.o could never work on OS X.
>  I am not sure that failing the build is intentional.  Markus, any clue?

ivshmem.o should only be linked when CONFIG_EVENTFD is set.  pci.mak has

    CONFIG_IVSHMEM=$(CONFIG_EVENTFD)

The compile error shown above indicates CONFIG_EVENTFD=y for make (since
ivshmem.o gets linked), but !defined(CONFIG_EVENTFD) for C (or else
event_notifier_init_fd() would exist).  Your build tree is messed up, or
the makefiles are broken.  Try starting over with a fresh build tree.

  reply	other threads:[~2016-04-08 11:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 16:35 [Qemu-devel] [PATCH] fix missing event_notifier_init_fd() function on Mac OS X Programmingkid
2016-03-30 16:38 ` Paolo Bonzini
2016-04-08 11:25   ` Markus Armbruster [this message]
2016-04-14 18:24     ` Programmingkid
2016-04-14 18:39       ` Peter Maydell
2016-04-14 18:47         ` Programmingkid
2016-04-14 18:58           ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2k8wde7.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.