From: aneesh.kumar@linux.vnet.ibm.com (Aneesh Kumar K.V)
To: linux-snps-arc@lists.infradead.org
Subject: Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range")
Date: Tue, 22 Mar 2016 10:44:45 +0530 [thread overview]
Message-ID: <87k2kvt7p6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160321200035.GA31544@roeck-us.net>
Guenter Roeck <linux at roeck-us.net> writes:
> [ text/plain ]
> Hi,
>
> Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range
> to flush_pmd_tlb_range") causes a build error when building
> arcv2:vdk_hs38_smp_defconfig.
>
> include/asm-generic/pgtable.h:799:45: note: in expansion of macro ?BUILD_BUG?
> #define flush_pmd_tlb_range(vma, addr, end) BUILD_BUG()
> ^
> ./arch/arc/include/asm/tlbflush.h:37:13: note:
> in expansion of macro ?flush_pmd_tlb_range?
>
> The build triggers the newly introduced BUILD_BUG().
>
> When building the image without the BUILD_BUG(), ie with no definition
> of flush_pmd_tlb_range(), the problem is gone. This suggests that the
> function is not needed for this build.
>
> I could submit a patch to remove the BUILD_BUG(), but maybe you had a reason
> for introducing it. Can you elaborate why you introduced the BUILD_BUG() ?
>
Isn't this going to be fixed by an update to ARC tree ?
http://article.gmane.org/gmane.linux.kernel.mm/148412
I also don't understand why we would hit that BUILD_BUG, if we are not
calling flush_pmd_tlb_range().
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@synopsys.com>
Subject: Re: Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range")
Date: Tue, 22 Mar 2016 10:44:45 +0530 [thread overview]
Message-ID: <87k2kvt7p6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160321200035.GA31544@roeck-us.net>
Guenter Roeck <linux@roeck-us.net> writes:
> [ text/plain ]
> Hi,
>
> Your commit 458aa76d132dc1 ("mm/thp/migration: switch from flush_tlb_range
> to flush_pmd_tlb_range") causes a build error when building
> arcv2:vdk_hs38_smp_defconfig.
>
> include/asm-generic/pgtable.h:799:45: note: in expansion of macro ‘BUILD_BUG’
> #define flush_pmd_tlb_range(vma, addr, end) BUILD_BUG()
> ^
> ./arch/arc/include/asm/tlbflush.h:37:13: note:
> in expansion of macro ‘flush_pmd_tlb_range’
>
> The build triggers the newly introduced BUILD_BUG().
>
> When building the image without the BUILD_BUG(), ie with no definition
> of flush_pmd_tlb_range(), the problem is gone. This suggests that the
> function is not needed for this build.
>
> I could submit a patch to remove the BUILD_BUG(), but maybe you had a reason
> for introducing it. Can you elaborate why you introduced the BUILD_BUG() ?
>
Isn't this going to be fixed by an update to ARC tree ?
http://article.gmane.org/gmane.linux.kernel.mm/148412
I also don't understand why we would hit that BUILD_BUG, if we are not
calling flush_pmd_tlb_range().
-aneesh
next prev parent reply other threads:[~2016-03-22 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 20:00 Build error due to commit 458aa76d132dc ("mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range") Guenter Roeck
2016-03-21 20:00 ` Guenter Roeck
2016-03-22 5:14 ` Aneesh Kumar K.V [this message]
2016-03-22 5:14 ` Aneesh Kumar K.V
2016-03-22 11:19 ` Guenter Roeck
2016-03-22 11:19 ` Guenter Roeck
2016-03-28 7:04 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2kvt7p6.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.