All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Oh, Peter" <poh@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v3] ath10k: set MAC timestamp in management Rx frame
Date: Thu, 25 Feb 2016 16:34:45 +0000	[thread overview]
Message-ID: <87k2lsd9zv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4c705dc7a2c0aa857da4e6eaf6e8ed47c354b9ea.1456351768.git.poh@qca.qualcomm.com> (Peter Oh's message of "Wed, 24 Feb 2016 14:18:51 -0800")

Peter Oh <poh@qca.qualcomm.com> writes:

> Check and set Rx MAC timestamp when firmware indicates it.
> Firmware adds it in Rx beacon frame only at this moment.
> Driver and mac80211 may utilize it to detect such clockdrift
> or beacon collision and use the result for beacon collision
> avoidance.
>
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
> ---
>
> v2:
> 	- fix kbuild test robot warning, left shift count >= width of type,
> 	at __le32_to_cpu(arg.ext_info.rx_mac_timestamp_u32) << 32
> v3:
> 	- correct ext_info to start 4-byte aligned
> 	- make struct wmi_mgmt_rx_ext_info 4-byte aligned to comply FW's intention.

I see new warnings:

drivers/net/wireless/ath/ath10k/wmi.c:2199:16: warning: restricted __le32 degrades to integer
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 degrades to integer
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 degrades to integer

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Oh, Peter" <poh@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] ath10k: set MAC timestamp in management Rx frame
Date: Thu, 25 Feb 2016 16:34:45 +0000	[thread overview]
Message-ID: <87k2lsd9zv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <4c705dc7a2c0aa857da4e6eaf6e8ed47c354b9ea.1456351768.git.poh@qca.qualcomm.com> (Peter Oh's message of "Wed, 24 Feb 2016 14:18:51 -0800")

Peter Oh <poh@qca.qualcomm.com> writes:

> Check and set Rx MAC timestamp when firmware indicates it.
> Firmware adds it in Rx beacon frame only at this moment.
> Driver and mac80211 may utilize it to detect such clockdrift
> or beacon collision and use the result for beacon collision
> avoidance.
>
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
> ---
>
> v2:
> 	- fix kbuild test robot warning, left shift count >= width of type,
> 	at __le32_to_cpu(arg.ext_info.rx_mac_timestamp_u32) << 32
> v3:
> 	- correct ext_info to start 4-byte aligned
> 	- make struct wmi_mgmt_rx_ext_info 4-byte aligned to comply FW's intention.

I see new warnings:

drivers/net/wireless/ath/ath10k/wmi.c:2199:16: warning: restricted __le32 degrades to integer
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 degrades to integer
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: cast to restricted __le32
drivers/net/wireless/ath/ath10k/wmi.c:2201:41: warning: restricted __le32 degrades to integer

-- 
Kalle Valo

  reply	other threads:[~2016-02-25 16:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 22:18 [PATCH v3] ath10k: set MAC timestamp in management Rx frame Peter Oh
2016-02-24 22:18 ` Peter Oh
2016-02-25 16:34 ` Valo, Kalle [this message]
2016-02-25 16:34   ` Valo, Kalle
2016-02-25 18:53   ` Peter Oh
2016-02-25 18:53     ` Peter Oh
2016-02-25 19:32     ` Sven Eckelmann
2016-02-25 19:32       ` Sven Eckelmann
2016-02-25 19:49       ` Peter Oh
2016-02-25 19:49         ` Peter Oh
2016-02-26 10:00     ` Valo, Kalle
2016-02-26 10:00       ` Valo, Kalle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2lsd9zv.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=poh@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.