From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 4/5] ath10k: split reset logic from power up
Date: Mon, 13 Oct 2014 10:38:54 +0300 [thread overview]
Message-ID: <87k344a06p.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1412842950-14098-5-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 9 Oct 2014 10:22:29 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> The power up procedure was overly complex due to
> warm/cold reset workarounds and issues.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> + ret = ath10k_pci_wait_for_target_init(ar);
> + if (ret) {
> + ath10k_warn(ar, "failed to wait for target after cold reset: %d\n",
> + ret);
Checkpatch warns:
ath10k/pci.c:1849: CHECK: Alignment should match open parenthesis
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/5] ath10k: split reset logic from power up
Date: Mon, 13 Oct 2014 10:38:54 +0300 [thread overview]
Message-ID: <87k344a06p.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1412842950-14098-5-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 9 Oct 2014 10:22:29 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> The power up procedure was overly complex due to
> warm/cold reset workarounds and issues.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> + ret = ath10k_pci_wait_for_target_init(ar);
> + if (ret) {
> + ath10k_warn(ar, "failed to wait for target after cold reset: %d\n",
> + ret);
Checkpatch warns:
ath10k/pci.c:1849: CHECK: Alignment should match open parenthesis
--
Kalle Valo
next prev parent reply other threads:[~2014-10-13 7:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 8:22 [PATCH 0/5] ath10k: pci related fixes 2014-10-09 Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-09 8:22 ` [PATCH 1/5] ath10k: re-disable interrupts after target init Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-09 8:22 ` [PATCH 2/5] ath10k: mask/unmask msi fw irq Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-09 8:22 ` [PATCH 3/5] ath10k: make warm reset a bit safer and faster Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-10 7:36 ` Michal Kazior
2014-10-10 7:36 ` Michal Kazior
2014-10-09 8:22 ` [PATCH 4/5] ath10k: split reset logic from power up Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-13 7:38 ` Kalle Valo [this message]
2014-10-13 7:38 ` Kalle Valo
2014-10-09 8:22 ` [PATCH 5/5] ath10k: replace power up/down with reset callback Michal Kazior
2014-10-09 8:22 ` Michal Kazior
2014-10-13 8:01 ` Kalle Valo
2014-10-13 8:01 ` Kalle Valo
2014-10-13 8:25 ` Michal Kazior
2014-10-13 8:25 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k344a06p.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.