From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PULL 1/1] spice: auth fixes
Date: Fri, 11 Jul 2014 13:18:04 +0200 [thread overview]
Message-ID: <87k37k9mab.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1405071380-13652-2-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Fri, 11 Jul 2014 11:36:20 +0200")
Gerd Hoffmann <kraxel@redhat.com> writes:
> Set auth to sasl when sasl is enabled, this makes "info spice" correctly
> display sasl auth.
Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it?
If yes, I'd recommend to note this in the commit message.
> Also throw an error in case someone tries to set
> a spice password via monitor without auth mode being "spice".
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Since the patch looks fine to me:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2014-07-11 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 9:36 [Qemu-devel] [PULL 0/1] spice: auth fixes Gerd Hoffmann
2014-07-11 9:36 ` [Qemu-devel] [PULL 1/1] " Gerd Hoffmann
2014-07-11 11:18 ` Markus Armbruster [this message]
2014-07-11 11:20 ` Peter Maydell
2014-07-11 11:36 ` Markus Armbruster
2014-07-11 15:00 ` [Qemu-devel] [PULL 0/1] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k37k9mab.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.