From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] ath10k: split the if_limits and if_comb
Date: Mon, 16 Dec 2013 16:13:36 +0200 [thread overview]
Message-ID: <87k3f4g9yn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1386688840-12181-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Tue, 10 Dec 2013 16:20:39 +0100")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> Split the interface limits and inteface combination,
> to reflect the 10.X capabilites (no P2P, no STA and 8 VAP).
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
Both patches applied. I did minor changes in patch 1, please double
check:
> @@ -3717,8 +3718,15 @@ int ath10k_mac_register(struct ath10k *ar)
> */
> ar->hw->queues = 4;
>
> - ar->hw->wiphy->iface_combinations = ath10k_if_comb;
> - ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_if_comb);
> + if (!test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) {
> +
> + ar->hw->wiphy->iface_combinations = ath10k_if_comb;
> + ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_if_comb);
> +
> + } else {
> + ar->hw->wiphy->iface_combinations = ath10k_10x_if_comb;
> + ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_10x_if_comb);
> + }
I fixed checkpatch warnings here and reversed the test to get rid
unnecessary negation operator.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: split the if_limits and if_comb
Date: Mon, 16 Dec 2013 16:13:36 +0200 [thread overview]
Message-ID: <87k3f4g9yn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1386688840-12181-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Tue, 10 Dec 2013 16:20:39 +0100")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> Split the interface limits and inteface combination,
> to reflect the 10.X capabilites (no P2P, no STA and 8 VAP).
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
Both patches applied. I did minor changes in patch 1, please double
check:
> @@ -3717,8 +3718,15 @@ int ath10k_mac_register(struct ath10k *ar)
> */
> ar->hw->queues = 4;
>
> - ar->hw->wiphy->iface_combinations = ath10k_if_comb;
> - ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_if_comb);
> + if (!test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) {
> +
> + ar->hw->wiphy->iface_combinations = ath10k_if_comb;
> + ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_if_comb);
> +
> + } else {
> + ar->hw->wiphy->iface_combinations = ath10k_10x_if_comb;
> + ar->hw->wiphy->n_iface_combinations = ARRAY_SIZE(ath10k_10x_if_comb);
> + }
I fixed checkpatch warnings here and reversed the test to get rid
unnecessary negation operator.
--
Kalle Valo
next prev parent reply other threads:[~2013-12-16 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 15:20 [PATCH 1/2] ath10k: split the if_limits and if_comb Bartosz Markowski
2013-12-10 15:20 ` Bartosz Markowski
2013-12-10 15:20 ` [PATCH 2/2] ath10k: introduce NO_P2P fw feature flag Bartosz Markowski
2013-12-10 15:20 ` Bartosz Markowski
2013-12-10 15:35 ` [PATCH 1/2] ath10k: split the if_limits and if_comb Ben Greear
2013-12-10 15:35 ` Ben Greear
2013-12-16 13:55 ` Kalle Valo
2013-12-16 13:55 ` Kalle Valo
2013-12-16 14:13 ` Kalle Valo [this message]
2013-12-16 14:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3f4g9yn.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.