From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 07/13] ath10k: implement host memory chunks
Date: Thu, 26 Sep 2013 12:04:12 +0300 [thread overview]
Message-ID: <87k3i4rm2b.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380101891-18312-8-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Wed, 25 Sep 2013 11:38:05 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> 10.X firmware can request a memory pool from host to offload
> it's own resources. This is a feature designed especially
> for AP mode where the target has to deal with large number
> of peers.
>
> So we allocate and map a consistent DMA memory which FW can
> use to store e.g. peer rate contol maps.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
[...]
> + if (num_unit_info) {
> + if (num_unit_info & NUM_UNITS_IS_NUM_PEERS)
> + /* number of units to allocate is number of
> + * peers, 1 extra for self peer on target */
> + /* this needs to be tied, host and target
> + * can get out of sync */
> + num_units = TARGET_NUM_PEERS + 1;
> + if (num_unit_info & NUM_UNITS_IS_NUM_VDEVS)
> + num_units = TARGET_NUM_VDEVS + 1;
> + }
The outer if test looks useless. I think this can be simplified to just:
if (num_unit_info & NUM_UNITS_IS_NUM_PEERS)
....
else if (num_unit_info & NUM_UNITS_IS_NUM_VDEVS)
...
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 07/13] ath10k: implement host memory chunks
Date: Thu, 26 Sep 2013 12:04:12 +0300 [thread overview]
Message-ID: <87k3i4rm2b.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380101891-18312-8-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Wed, 25 Sep 2013 11:38:05 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> 10.X firmware can request a memory pool from host to offload
> it's own resources. This is a feature designed especially
> for AP mode where the target has to deal with large number
> of peers.
>
> So we allocate and map a consistent DMA memory which FW can
> use to store e.g. peer rate contol maps.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
[...]
> + if (num_unit_info) {
> + if (num_unit_info & NUM_UNITS_IS_NUM_PEERS)
> + /* number of units to allocate is number of
> + * peers, 1 extra for self peer on target */
> + /* this needs to be tied, host and target
> + * can get out of sync */
> + num_units = TARGET_NUM_PEERS + 1;
> + if (num_unit_info & NUM_UNITS_IS_NUM_VDEVS)
> + num_units = TARGET_NUM_VDEVS + 1;
> + }
The outer if test looks useless. I think this can be simplified to just:
if (num_unit_info & NUM_UNITS_IS_NUM_PEERS)
....
else if (num_unit_info & NUM_UNITS_IS_NUM_VDEVS)
...
--
Kalle Valo
next prev parent reply other threads:[~2013-09-26 9:04 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 9:37 [PATCH 00/13] ath10k: dual-firmware support (MAIN and 10.X) Bartosz Markowski
2013-09-25 9:37 ` Bartosz Markowski
2013-09-25 9:37 ` [PATCH 01/13] ath10k: introduce dynamic WMI structures Bartosz Markowski
2013-09-25 9:37 ` Bartosz Markowski
2013-09-25 10:38 ` Michal Kazior
2013-09-25 10:38 ` Michal Kazior
2013-09-26 8:12 ` Kalle Valo
2013-09-26 8:12 ` Kalle Valo
2013-09-26 8:54 ` Kalle Valo
2013-09-26 8:54 ` Kalle Valo
2013-09-26 9:03 ` Michal Kazior
2013-09-26 9:03 ` Michal Kazior
2013-09-26 9:07 ` Kalle Valo
2013-09-26 9:07 ` Kalle Valo
2013-09-25 9:38 ` [PATCH 02/13] ath10k: add wmi_10x_<cmd/event> definitions Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 03/13] ath10k: warn if give WMI command is not supported Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 04/13] ath10k: implement WMI events handling frame for both firmwares Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 05/13] ath10k: split ath10k_wmi_service_ready_event_rx Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 06/13] ath10k: drop the fw versioning sanity check Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 07/13] ath10k: implement host memory chunks Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-26 9:04 ` Kalle Valo [this message]
2013-09-26 9:04 ` Kalle Valo
2013-09-25 9:38 ` [PATCH 08/13] ath10k: bring back the WMI path for mgmt frames Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 10:46 ` Michal Kazior
2013-09-25 10:46 ` Michal Kazior
2013-09-25 9:38 ` [PATCH 09/13] ath10k: split wmi_cmd_init path Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-26 8:15 ` Kalle Valo
2013-09-26 8:15 ` Kalle Valo
2013-09-25 9:38 ` [PATCH 10/13] ath10k: add TARGET values for 10.x firmware Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 9:38 ` [PATCH 11/13] ath10k: introduce dynamic vdev parameters Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 10:38 ` Michal Kazior
2013-09-25 10:38 ` Michal Kazior
2013-09-25 9:38 ` [PATCH 12/13] ath10k: introduce dynamic pdev parameters Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
2013-09-25 10:39 ` Michal Kazior
2013-09-25 10:39 ` Michal Kazior
2013-09-25 9:38 ` [PATCH 13/13] ath10k: handle FW API differences for scan structures Bartosz Markowski
2013-09-25 9:38 ` Bartosz Markowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3i4rm2b.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.