From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: Stefan Weil <sw@weilnetz.de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
Date: Thu, 04 Jul 2013 10:24:44 +0530 [thread overview]
Message-ID: <87k3l6c4bv.fsf@in.ibm.com> (raw)
In-Reply-To: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
Stefan Weil <sw@weilnetz.de> writes:
> This leak was reported by cppcheck.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
> fsdev/qemu-fsdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
> index 6eaf36d..ccfec13 100644
> --- a/fsdev/qemu-fsdev.c
> +++ b/fsdev/qemu-fsdev.c
> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>
> if (fsle->fse.ops->parse_opts) {
> if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
> + g_free(fsle->fse.fsdev_id);
> + g_free(fsle);
> return -1;
> }
> }
> --
> 1.7.10.4
next prev parent reply other threads:[~2013-07-04 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 10:02 [Qemu-devel] [PATCH] fsdev: Fix potential memory leak Stefan Weil
2013-07-02 20:35 ` Stefan Weil
2013-07-07 17:15 ` Aneesh Kumar K.V
2013-07-07 19:41 ` Stefan Weil
2013-07-04 4:54 ` M. Mohan Kumar [this message]
2013-07-10 19:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3l6c4bv.fsf@in.ibm.com \
--to=mohan@in.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.