Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Stefan Weil <sw@weilnetz.de> writes:

> Am 16.06.2013 12:02, schrieb Stefan Weil:
>> This leak was reported by cppcheck.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  fsdev/qemu-fsdev.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
>> index 6eaf36d..ccfec13 100644
>> --- a/fsdev/qemu-fsdev.c
>> +++ b/fsdev/qemu-fsdev.c
>> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>>  
>>      if (fsle->fse.ops->parse_opts) {
>>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
>> +            g_free(fsle->fse.fsdev_id);
>> +            g_free(fsle);
>>              return -1;
>>          }
>>      }
>
> Ping?

Both the error path result in Qemu terminating right ? Do we really care
about free in those case ?

-aneesh