All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "Dmitry Tarnyagin" <dmitry.tarnyagin@stericsson.com>,
	"Sjur Brændeland" <sjur@brendeland.net>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Ido Yariv" <ido@wizery.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Erwan Yvin" <erwan.yvin@stericsson.com>,
	virtualization <virtualization@lists.linux-foundation.org>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	"Sjur Brændeland" <sjur.brandeland@stericsson.com>
Subject: Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)
Date: Fri, 22 Feb 2013 11:12:13 +1030	[thread overview]
Message-ID: <87k3q1faca.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbYt6mQeJ+4kCFsfGppfaq3JcS6OedNE+ZGd4itfR1hU4A@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery.com> writes:
> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>> Hmm... I clearly jumped the gun, assuming consensus was already reached.
>> I have put these patches *back* into pending-rebases, and they will not
>> be merged this merge window.
>
> Thanks.
>
> What do you think about creating some virtio-level wrappers for the
> vringh handlers?
>
> I don't think we're going to stop with caif as the only vringh user,
> and it could be nice if we follow the virtio spirit of decoupling the
> drivers from the low level implementation. It sure did prove itself
> when the remoteproc use cases started showing up, and it's neat.

The problem space is a bit different.  My immediate concern is getting
vhost (and thus vhost_net/blk) to use vringh: I wanted to unify the
in-userspace and in-kernelspace ring implementations.  We don't have
that issue in virtqueue.c.

vhost is (will be) the higher abstraction for in-userspace rings,
perhaps we want an equivalent for in-kernelspace rings.  I'm happy to
look at patches, but I don't immediately see what it would look like...

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "Sjur Brændeland" <sjur.brandeland@stericsson.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Sjur Brændeland" <sjur@brendeland.net>,
	netdev@vger.kernel.org,
	virtualization <virtualization@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Dmitry Tarnyagin" <dmitry.tarnyagin@stericsson.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Erwan Yvin" <erwan.yvin@stericsson.com>,
	"Ido Yariv" <ido@wizery.com>
Subject: Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)
Date: Fri, 22 Feb 2013 11:12:13 +1030	[thread overview]
Message-ID: <87k3q1faca.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbYt6mQeJ+4kCFsfGppfaq3JcS6OedNE+ZGd4itfR1hU4A@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery.com> writes:
> On Thu, Feb 21, 2013 at 8:37 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>> Hmm... I clearly jumped the gun, assuming consensus was already reached.
>> I have put these patches *back* into pending-rebases, and they will not
>> be merged this merge window.
>
> Thanks.
>
> What do you think about creating some virtio-level wrappers for the
> vringh handlers?
>
> I don't think we're going to stop with caif as the only vringh user,
> and it could be nice if we follow the virtio spirit of decoupling the
> drivers from the low level implementation. It sure did prove itself
> when the remoteproc use cases started showing up, and it's neat.

The problem space is a bit different.  My immediate concern is getting
vhost (and thus vhost_net/blk) to use vringh: I wanted to unify the
in-userspace and in-kernelspace ring implementations.  We don't have
that issue in virtqueue.c.

vhost is (will be) the higher abstraction for in-userspace rings,
perhaps we want an equivalent for in-kernelspace rings.  I'm happy to
look at patches, but I don't immediately see what it would look like...

Thanks,
Rusty.

  reply	other threads:[~2013-02-22  0:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 11:49 [PATCHv2 vringh 0/3] Introduce CAIF Virtio driver sjur.brandeland
2013-02-12 11:49 ` sjur.brandeland
2013-02-12 11:49 ` [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings) sjur.brandeland
2013-02-12 11:49   ` sjur.brandeland
2013-02-20 16:05   ` Ohad Ben-Cohen
2013-02-20 16:05     ` Ohad Ben-Cohen
2013-02-20 23:01     ` Sjur Brændeland
2013-02-20 23:01       ` Sjur Brændeland
2013-02-21 13:47       ` Ohad Ben-Cohen
2013-02-21 13:47         ` Ohad Ben-Cohen
2013-02-21 17:28         ` Sjur Brændeland
2013-02-21 17:28           ` Sjur Brændeland
2013-02-21 17:55           ` Ohad Ben-Cohen
2013-02-21 17:55             ` Ohad Ben-Cohen
2013-02-21 19:36             ` Sjur Brændeland
2013-02-21 19:36               ` Sjur Brændeland
2013-02-23  9:49               ` Ohad Ben-Cohen
2013-02-23  9:49                 ` Ohad Ben-Cohen
2013-02-21  6:37     ` Rusty Russell
2013-02-21  6:37       ` Rusty Russell
2013-02-21 13:53       ` Ohad Ben-Cohen
2013-02-21 13:53         ` Ohad Ben-Cohen
2013-02-22  0:42         ` Rusty Russell [this message]
2013-02-22  0:42           ` Rusty Russell
2013-02-12 11:49 ` [PATCHv2 vringh 2/3] virtio: Add module driver macro for virtio drivers sjur.brandeland
2013-02-12 11:49 ` sjur.brandeland
2013-02-12 11:49 ` [PATCHv2 vringh 3/3] caif_virtio: Introduce caif over virtio sjur.brandeland
2013-02-12 11:49 ` sjur.brandeland
2013-02-18 23:37   ` Rusty Russell
2013-02-18 23:37   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3q1faca.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davem@davemloft.net \
    --cc=dmitry.tarnyagin@stericsson.com \
    --cc=erwan.yvin@stericsson.com \
    --cc=ido@wizery.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=sjur.brandeland@stericsson.com \
    --cc=sjur@brendeland.net \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.