From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: "Lukáš Czerner" <lczerner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
Zhao Hongjiang
<zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ext3: fix return values on parse_options() failure
Date: Mon, 08 Oct 2012 23:50:26 -0700 [thread overview]
Message-ID: <87k3v0cf65.fsf@xmission.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1210090814420.11244-462rkM2+8ahgDJpvDrVWWBcY2uh10dtjAL8bYrjMMd8@public.gmane.org> ("Lukáš Czerner"'s message of "Tue, 9 Oct 2012 08:19:42 +0200 (CEST)")
Lukáš Czerner <lczerner@redhat.com> writes:
> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
>
>> Date: Tue, 09 Oct 2012 13:48:47 +0800
>> From: Zhao Hongjiang <zhaohongjiang37@gmail.com>
>> To: jack@suse.cz
>> Cc: akpm@linux-foundation.org, adilger.kernel@dilger.ca,
>> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
>> Eric W. Biederman <ebiederm@xmission.com>, serge.hallyn@canonical.com,
>> containers@lists.linux-foundation.org
>> Subject: [PATCH] ext3: fix return values on parse_options() failure
>>
>> From: Zhao Hongjiang <zhaohongjiang@huawei.com>
>>
>> parse_options() in ext3 should return 0 when parse the mount options fails.
>>
>
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Ugh. I goofed that up. How annoying that ext4 is different than ext3
and ext2 in this regard.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Zhao Hongjiang <zhaohongjiang37@gmail.com>,
jack@suse.cz, akpm@linux-foundation.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, serge.hallyn@canonical.com,
containers@lists.linux-foundation.org
Subject: Re: [PATCH] ext3: fix return values on parse_options() failure
Date: Mon, 08 Oct 2012 23:50:26 -0700 [thread overview]
Message-ID: <87k3v0cf65.fsf@xmission.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1210090814420.11244@dhcp-1-104.brq.redhat.com> ("Lukáš Czerner"'s message of "Tue, 9 Oct 2012 08:19:42 +0200 (CEST)")
Lukáš Czerner <lczerner@redhat.com> writes:
> On Tue, 9 Oct 2012, Zhao Hongjiang wrote:
>
>> Date: Tue, 09 Oct 2012 13:48:47 +0800
>> From: Zhao Hongjiang <zhaohongjiang37@gmail.com>
>> To: jack@suse.cz
>> Cc: akpm@linux-foundation.org, adilger.kernel@dilger.ca,
>> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
>> Eric W. Biederman <ebiederm@xmission.com>, serge.hallyn@canonical.com,
>> containers@lists.linux-foundation.org
>> Subject: [PATCH] ext3: fix return values on parse_options() failure
>>
>> From: Zhao Hongjiang <zhaohongjiang@huawei.com>
>>
>> parse_options() in ext3 should return 0 when parse the mount options fails.
>>
>
> Ah, it really is a joy to read the parse_options() :). But this fix
> makes sense, thanks for catching it.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Ugh. I goofed that up. How annoying that ext4 is different than ext3
and ext2 in this regard.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
next prev parent reply other threads:[~2012-10-09 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 5:48 [PATCH] ext3: fix return values on parse_options() failure Zhao Hongjiang
2012-10-09 5:48 ` Zhao Hongjiang
2012-10-09 6:19 ` Lukáš Czerner
[not found] ` <alpine.LFD.2.00.1210090814420.11244-462rkM2+8ahgDJpvDrVWWBcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
2012-10-09 6:50 ` Eric W. Biederman [this message]
2012-10-09 6:50 ` Eric W. Biederman
2012-10-09 21:24 ` Jan Kara
2012-10-09 21:24 ` Jan Kara
2012-10-09 21:24 ` Jan Kara
[not found] ` <5073BABF.8090206-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-09 6:19 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3v0cf65.fsf@xmission.com \
--to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=lczerner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.