From: ebiederm@xmission.com (Eric W. Biederman)
To: Simon Budig <simon.budig@kernelconcepts.de>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH] Input: Let the FT5x06 driver build without debugfs
Date: Thu, 16 Aug 2012 17:15:16 -0700 [thread overview]
Message-ID: <87k3wy1ii3.fsf@xmission.com> (raw)
When testing to make certain my user namespace code works
in various configurations I tripped over the tf5x06.c not
building with debugfs disabled.
drivers/input/touchscreen/edt-ft5x06.c: In function ‘edt_ft5x06_ts_remove’:
drivers/input/touchscreen/edt-ft5x06.c:846:14: error: ‘struct edt_ft5x06_ts_data’ has no member named ‘raw_buffer’
Fix the build by placing an #ifdef around the problem kfree.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 9afc777..bc160b3 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -843,7 +843,9 @@ static int __devexit edt_ft5x06_ts_remove(struct i2c_client *client)
if (gpio_is_valid(pdata->reset_pin))
gpio_free(pdata->reset_pin);
+#if defined(CONFIG_DEBUG_FS)
kfree(tsdata->raw_buffer);
+#endif
kfree(tsdata);
return 0;
--
1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman)
To: Simon Budig <simon.budig@kernelconcepts.de>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: [PATCH] Input: Let the FT5x06 driver build without debugfs
Date: Thu, 16 Aug 2012 17:15:16 -0700 [thread overview]
Message-ID: <87k3wy1ii3.fsf@xmission.com> (raw)
When testing to make certain my user namespace code works
in various configurations I tripped over the tf5x06.c not
building with debugfs disabled.
drivers/input/touchscreen/edt-ft5x06.c: In function ‘edt_ft5x06_ts_remove’:
drivers/input/touchscreen/edt-ft5x06.c:846:14: error: ‘struct edt_ft5x06_ts_data’ has no member named ‘raw_buffer’
Fix the build by placing an #ifdef around the problem kfree.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 9afc777..bc160b3 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -843,7 +843,9 @@ static int __devexit edt_ft5x06_ts_remove(struct i2c_client *client)
if (gpio_is_valid(pdata->reset_pin))
gpio_free(pdata->reset_pin);
+#if defined(CONFIG_DEBUG_FS)
kfree(tsdata->raw_buffer);
+#endif
kfree(tsdata);
return 0;
--
1.7.5.4
next reply other threads:[~2012-08-17 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 0:15 Eric W. Biederman [this message]
2012-08-17 0:15 ` [PATCH] Input: Let the FT5x06 driver build without debugfs Eric W. Biederman
2012-08-17 8:09 ` Simon Budig
2012-08-17 19:21 ` Eric W. Biederman
2012-08-20 13:53 ` Guenter Roeck
2012-08-22 5:49 ` Dmitry Torokhov
2012-08-30 22:26 ` David Rientjes
2012-08-30 22:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3wy1ii3.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.