From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support
Date: Tue, 11 Oct 2011 10:00:25 -0700 [thread overview]
Message-ID: <87k48b79au.fsf@ti.com> (raw)
In-Reply-To: <4E93EBC2.1060103@ti.com> (Santosh Shilimkar's message of "Tue, 11 Oct 2011 12:39:54 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On Monday 10 October 2011 11:31 PM, Kevin Hilman wrote:
>> Hi Santosh,
>>
>> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>>
>>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for
>>> suspend (S2R), CPU hotplug and CPUidle.
>>
>> There are a few more compile errors when doing OMAP1-only builds.
>> You'll need a way to eliminate the secure calls for OMAP1.
>>
>> This series causes a couple build errors when doing OMAP1-only builds
>> (I used omap1_defconfig):
>>
> OK. Thanks for catching it.
>
>> First:
>>
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:24:30: fatal error: mach/omap-secure.h: No such file or directory
>>
>> And trying creating a dummy header to see if it would continue to build gives:
>>
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c: In function 'omap_reserve':
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:70:2: error: implicit declaration of function 'omap_secure_ram_reserve_memblock'
>> make[2]: *** [arch/arm/plat-omap/common.o] Error 1
>> make[1]: *** [arch/arm/plat-omap] Error 2
>>
> For OMAP1 build, omap_secure_ram_reserve_memblock() definition is
> needed since common.c is built for OMAP1 as well.
> The trivial change in the end of this email fixes the omap1 build.
Looks good.
> Have folded that change in original patch and updated the OMAP4
> PM branch - for_3_2/omap4-mpuss-pm_2
Thanks.
> Regards
> Santosh
> P.S : Even with this fix, omap1_defconfig build breaks because of USB.
> I removed USB from build to check rest of the build and it was
> fine then.
OK.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support
Date: Tue, 11 Oct 2011 10:00:25 -0700 [thread overview]
Message-ID: <87k48b79au.fsf@ti.com> (raw)
In-Reply-To: <4E93EBC2.1060103@ti.com> (Santosh Shilimkar's message of "Tue, 11 Oct 2011 12:39:54 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On Monday 10 October 2011 11:31 PM, Kevin Hilman wrote:
>> Hi Santosh,
>>
>> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>>
>>> The series adds OMAP4 MPUSS (MPU SubSystem) power management support for
>>> suspend (S2R), CPU hotplug and CPUidle.
>>
>> There are a few more compile errors when doing OMAP1-only builds.
>> You'll need a way to eliminate the secure calls for OMAP1.
>>
>> This series causes a couple build errors when doing OMAP1-only builds
>> (I used omap1_defconfig):
>>
> OK. Thanks for catching it.
>
>> First:
>>
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:24:30: fatal error: mach/omap-secure.h: No such file or directory
>>
>> And trying creating a dummy header to see if it would continue to build gives:
>>
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c: In function 'omap_reserve':
>> /work/kernel/omap/pm/arch/arm/plat-omap/common.c:70:2: error: implicit declaration of function 'omap_secure_ram_reserve_memblock'
>> make[2]: *** [arch/arm/plat-omap/common.o] Error 1
>> make[1]: *** [arch/arm/plat-omap] Error 2
>>
> For OMAP1 build, omap_secure_ram_reserve_memblock() definition is
> needed since common.c is built for OMAP1 as well.
> The trivial change in the end of this email fixes the omap1 build.
Looks good.
> Have folded that change in original patch and updated the OMAP4
> PM branch - for_3_2/omap4-mpuss-pm_2
Thanks.
> Regards
> Santosh
> P.S : Even with this fix, omap1_defconfig build breaks because of USB.
> I removed USB from build to check rest of the build and it was
> fine then.
OK.
Kevin
next prev parent reply other threads:[~2011-10-11 17:00 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 6:14 [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 01/24] OMAP4: Use WARN_ON() instead of BUG_ON() with graceful exit Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 02/24] OMAP4: Export omap4_get_base*() rather than global address pointers Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 03/24] OMAP4: PM: Add SAR RAM support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 04/24] OMAP4: PM: Keep static dep between MPUSS-EMIF and MPUSS-L3/L4 and DUCATI-L3 Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 05/24] OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0 Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 06/24] OMAP4: PM: Initialise all the clockdomains to supported states Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 07/24] OMAP: Add Secure HAL and monitor mode API infrastructure Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 08/24] OMAP: PM: Add support to allocate the memory for secure RAM Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 09/24] OMAP4: PM: Add WakeupGen module as OMAP gic_arch_extn Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 10/24] OMAP4: PM: Add CPUX OFF mode support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 11/24] OMAP4: Remove __INIT from omap_secondary_startup() to re-use it for hotplug Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 12/24] OMAP4: PM: Program CPU1 to hit OFF when off-lined Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 13/24] OMAP4: PM: CPU1 wakeup workaround from Low power modes Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 14/24] OMAP4: PM: Use custom omap_do_wfi() for default idle Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 15/24] OMAP4: suspend: Add MPUSS power domain RETENTION support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 16/24] OMAP4: Remove un-used do_wfi() macro Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 17/24] OMAP4: PM: Add WakeupGen and secure GIC low power support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 18/24] OMAP4: PM: Add L2X0 cache lowpower support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 19/24] OMAP4: PM: Add MPUSS power domain OSWR support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 20/24] OMAP4: PM: Add power domain statistics support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 21/24] OMAP4: PM: Add CPUidle support Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 22/24] OMAP4: cpuidle: Switch to gptimer from twd in deeper C-states Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 23/24] OMAP3: CPUidle: Make use of CPU PM notifiers Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-09-24 6:14 ` [PATCH v2 24/24] OMAP4: Fix errata i688 with MPU interconnect barriers Santosh Shilimkar
2011-09-24 6:14 ` Santosh Shilimkar
2011-10-04 17:05 ` [PATCH 00/24 V2] OMAP4: PM: suspend, CPU-hotplug and CPUilde support Kevin Hilman
2011-10-04 17:05 ` Kevin Hilman
2011-10-05 7:43 ` Santosh Shilimkar
2011-10-05 7:43 ` Santosh Shilimkar
2011-10-07 22:35 ` Kevin Hilman
2011-10-07 22:35 ` Kevin Hilman
2011-10-07 22:50 ` Kevin Hilman
2011-10-07 22:50 ` Kevin Hilman
2011-10-08 8:44 ` Santosh Shilimkar
2011-10-08 8:44 ` Santosh Shilimkar
2011-10-10 18:01 ` Kevin Hilman
2011-10-10 18:01 ` Kevin Hilman
2011-10-11 7:09 ` Santosh Shilimkar
2011-10-11 7:09 ` Santosh Shilimkar
2011-10-11 17:00 ` Kevin Hilman [this message]
2011-10-11 17:00 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k48b79au.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.