From: Kevin Hilman <khilman@deeprootsystems.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions
Date: Fri, 12 Nov 2010 12:25:38 -0800 [thread overview]
Message-ID: <87k4kiqofx.fsf@deeprootsystems.com> (raw)
In-Reply-To: <AANLkTimL25m4X0Apynis-H7g7FVDLU7Cw8mV+q2fptK8@mail.gmail.com> (Andrei Emeltchenko's message of "Fri, 12 Nov 2010 09:51:11 +0200")
Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com> writes:
> Hi,
>
> On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
> <khilman@deeprootsystems.com> wrote:
>> Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> writes:
>>
>>> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>>>
>>> Define MDR1 register serial definitions used in serial and
>>> bluetooth drivers. Remove magic numbers there.
>>
>> Remove magic numbers where? This patch doesn't remove anything.
>
> We have code which is not yet upstream, it will come through Bluetooth
> subtree at some point, I am also going to remove magic in
> omapX/serial.c drivers in the next patches.
>
> Do you think I need to add those patches?
Not necessarly, but the comment should be a little more clear.
Something "subsequent patches will remove...."
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions
Date: Fri, 12 Nov 2010 12:25:38 -0800 [thread overview]
Message-ID: <87k4kiqofx.fsf@deeprootsystems.com> (raw)
In-Reply-To: <AANLkTimL25m4X0Apynis-H7g7FVDLU7Cw8mV+q2fptK8@mail.gmail.com> (Andrei Emeltchenko's message of "Fri, 12 Nov 2010 09:51:11 +0200")
Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com> writes:
> Hi,
>
> On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
> <khilman@deeprootsystems.com> wrote:
>> Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> writes:
>>
>>> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>>>
>>> Define MDR1 register serial definitions used in serial and
>>> bluetooth drivers. Remove magic numbers there.
>>
>> Remove magic numbers where? This patch doesn't remove anything.
>
> We have code which is not yet upstream, it will come through Bluetooth
> subtree at some point, I am also going to remove magic in
> omapX/serial.c drivers in the next patches.
>
> Do you think I need to add those patches?
Not necessarly, but the comment should be a little more clear.
Something "subsequent patches will remove...."
Kevin
next prev parent reply other threads:[~2010-11-12 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 14:13 [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions Emeltchenko Andrei
2010-11-11 16:02 ` Kevin Hilman
2010-11-12 7:51 ` Andrei Emeltchenko
2010-11-12 20:25 ` Kevin Hilman [this message]
2010-11-12 20:25 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4kiqofx.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.