Re: [PATCH v2 00/23] netoops support

[Andi Kleen <andi-Vw/NltI1exuRpAAqCnN02g@public.gmane.org>]

Mike Waychison <mikew-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> writes:

I'm still not fully convinced this needs to be a fully separate
mechanism from netconsole.  It seems a lot of work to implement
basically log level.

Maybe netconsole could be patched to support only dumping KERN_EMERG?

But I guess the structured logging has some advantages, although
there have been certainly oops parsers (e.g. kerneloops.org) without it.

>    * I am _NOT_ happy with the remaining userland ABIs presented in this
>      patchset.  Specifically the files "net_dump_now",
>      "net_dump_one_shot", "netdump_fw_version", "netdump_board_name"
>      and

fw_version and board_name is known by the kernel anyways through the DMI
interface, assuming the BIOS supplies that.  We also dump it already
on a standard oops. So why not just use that directly?

As a general user ABI perhaps simply an unstructured string is better
that is included in the packet.

-Andi

-- 
ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org -- Speaking for myself only.