All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Gerards <metgerards@student.han.nl>
To: ebik@ucw.cz
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: ext2 find patch
Date: Sun, 27 Jun 2004 12:45:41 +0200	[thread overview]
Message-ID: <87k6xt46ui.fsf@marco.marco-g.com> (raw)
In-Reply-To: <20040601201320.GA10705@artax.karlin.mff.cuni.cz> (Tomas Ebenlendr's message of "Tue, 1 Jun 2004 22:13:20 +0200")

ebik@artax.karlin.mff.cuni.cz (Tomas Ebenlendr) writes:

> The same problem was with symlinks, so the new version of patch is here.
>
> It does stat every inode (and ignore the info in direntries).
> There is also small fix in absolute symlinks (chopping the initial '/')

I've checked in your patch, after making some minor changes:

2004-06-27  Tomas Ebenlendr  <ebik@ucw.cz>

	* fs/ext2.c (FILETYPE_INO_MASK, FILETYPE_INO_DIRECTORY)
	(FILETYPE_INO_SYMLINK): New macros.
	(grub_ext2_find_file): Check if the node is a directory using the
	inode stat information instead of using the filetype in the
	dirent.  Exclude the first character of an absolute symlink.
	(grub_ext2_dir): Mask out the filetype part of the mode member of
	the inode.

I do not know why you moved the code to read the inode around.  I
didn't check that in.  Why is that required?

Please test if this works for you now.  It fixed my problem.

Thanks,
Marco




      parent reply	other threads:[~2004-06-27 10:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-01 12:17 ext2 find patch Tomas Ebenlendr
2004-06-01 20:13 ` Tomas Ebenlendr
2004-06-01 20:47   ` Marco Gerards
2004-06-01 21:09     ` Jeroen Dekkers
     [not found]     ` <20040602100915.GA1629@artax.karlin.mff.cuni.cz>
     [not found]       ` <1086176188.40bdbbbc4d86d@webmail.han.nl>
2004-06-02 14:43         ` normal vs. rescue mode commands Tomas Ebenlendr
2004-06-02 15:11           ` Tomas Ebenlendr
2004-06-02 16:10             ` Marco Gerards
2004-06-03 11:12               ` Yoshinori K. Okuji
2004-06-03 11:55                 ` M. Gerards
2004-06-03 12:50                 ` Tomas Ebenlendr
2004-06-04 11:24                   ` Yoshinori K. Okuji
2004-06-06 10:55                     ` Tomas Ebenlendr
2004-06-09 11:19                       ` Yoshinori K. Okuji
2004-06-09 12:07                         ` Jeroen Dekkers
2004-06-09 12:25                           ` Yoshinori K. Okuji
2004-06-09 12:48                             ` Jeroen Dekkers
2004-06-09 13:12                               ` Yoshinori K. Okuji
2004-06-09 13:54                                 ` Jeroen Dekkers
2004-06-09 14:22                                   ` Yoshinori K. Okuji
2004-06-09 14:44                                     ` Jeroen Dekkers
2004-06-10 11:51                                       ` Yoshinori K. Okuji
2004-06-09 12:28                         ` Tomas Ebenlendr
2004-06-09 12:31                           ` Tomas Ebenlendr
2004-06-03 11:08           ` Yoshinori K. Okuji
2004-06-27 10:45   ` Marco Gerards [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k6xt46ui.fsf@marco.marco-g.com \
    --to=metgerards@student.han.nl \
    --cc=ebik@ucw.cz \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.