Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Cornelia Huck <cohuck@redhat.com>]

On Thu, May 28 2026, Cédric Le Goater <clg@redhat.com> wrote:

> On 5/28/26 16:55, Cornelia Huck wrote:
>> On Sun, May 10 2026, zhaoguohan@kylinos.cn wrote:
>> 
>>> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>>>
>>> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
>>> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
>>> fails, but still return true to their callers.
>>>
>>> Return false after cleanup so callers can handle the failed registration
>>> path instead of treating it as a successful notifier setup.
>>>
>>> Please ignore the previous version.
>>>
>>> GuoHan Zhao (2):
>>>    vfio/ap: Return false when IRQ notifier setup fails
>>>    vfio/ccw: Return false when IRQ notifier setup fails
>>>
>>>   hw/vfio/ap.c  | 1 +
>>>   hw/vfio/ccw.c | 1 +
>>>   2 files changed, 2 insertions(+)
>>>
>> 
>> ...I guess this should go through the s390 tree (and not the vfio tree?)
>> If yes, I'll pick it up.
>> 
>
> I included these patches in my VFIO PR  last week. They are merged.
>
>    https://lore.kernel.org/qemu-devel/20260520162115.1613601-1-clg@redhat.com/
>
> Hope that's fine ? Sorry if not :/

Completely fine, thx, I just overlooked it :)