[PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[zhaoguohan]

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
fails, but still return true to their callers.

Return false after cleanup so callers can handle the failed registration
path instead of treating it as a successful notifier setup.

Please ignore the previous version.

GuoHan Zhao (2):
  vfio/ap: Return false when IRQ notifier setup fails
  vfio/ccw: Return false when IRQ notifier setup fails

 hw/vfio/ap.c  | 1 +
 hw/vfio/ccw.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0

[PATCH v2 1/2] vfio/ap: Return false when IRQ notifier setup fails

[zhaoguohan]

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

vfio_ap_register_irq_notifier() cleans up the fd handler and EventNotifier
when vfio_device_irq_set_signaling() fails, but still returns true to its
caller.

Return false after cleanup so the caller can handle the failed
registration path instead of treating it as a successful notifier setup.

Fixes: cbd470f0aac5 ("vfio/ap: Make vfio_ap_register_irq_notifier() return a bool")
Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
---
 hw/vfio/ap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 276ae8c207bf..6e2a1223ea8d 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -193,6 +193,7 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
                                        errp)) {
         qemu_set_fd_handler(fd, NULL, NULL, vapdev);
         event_notifier_cleanup(notifier);
+        return false;
     }
 
     return true;
-- 
2.43.0

Re: [PATCH v2 1/2] vfio/ap: Return false when IRQ notifier setup fails

[Anthony Krowiak]

On 5/10/26 4:43 AM, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>
> vfio_ap_register_irq_notifier() cleans up the fd handler and EventNotifier
> when vfio_device_irq_set_signaling() fails, but still returns true to its
> caller.
>
> Return false after cleanup so the caller can handle the failed
> registration path instead of treating it as a successful notifier setup.
>
> Fixes: cbd470f0aac5 ("vfio/ap: Make vfio_ap_register_irq_notifier() return a bool")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
>   hw/vfio/ap.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 276ae8c207bf..6e2a1223ea8d 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -193,6 +193,7 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
>                                          errp)) {
>           qemu_set_fd_handler(fd, NULL, NULL, vapdev);
>           event_notifier_cleanup(notifier);
> +        return false;

Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>

>       }
>   
>       return true;

[PATCH v2 2/2] vfio/ccw: Return false when IRQ notifier setup fails

[zhaoguohan]

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

vfio_ccw_register_irq_notifier() cleans up the fd handler and EventNotifier
when vfio_device_irq_set_signaling() fails, but still returns true to its
caller.

Return false after cleanup so the caller can handle the failed
registration path instead of treating it as a successful notifier setup.

Fixes: 8aaeff97acee ("vfio/ccw: Make vfio_ccw_register_irq_notifier() return a bool")
Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
---
 hw/vfio/ccw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index ff6ab9a7408f..c3dc7c196235 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -431,6 +431,7 @@ static bool vfio_ccw_register_irq_notifier(VFIOCCWDevice *vcdev,
                                        VFIO_IRQ_SET_ACTION_TRIGGER, fd, errp)) {
         qemu_set_fd_handler(fd, NULL, NULL, vcdev);
         event_notifier_cleanup(notifier);
+        return false;
     }
 
     return true;
-- 
2.43.0

Re: [PATCH v2 2/2] vfio/ccw: Return false when IRQ notifier setup fails

[Eric Farman]

On Sun, 2026-05-10 at 16:43 +0800, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ccw_register_irq_notifier() cleans up the fd handler and EventNotifier
> when vfio_device_irq_set_signaling() fails, but still returns true to its
> caller.
> 
> Return false after cleanup so the caller can handle the failed
> registration path instead of treating it as a successful notifier setup.
> 
> Fixes: 8aaeff97acee ("vfio/ccw: Make vfio_ccw_register_irq_notifier() return a bool")
> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>
> ---
>  hw/vfio/ccw.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Farman <farman@linux.ibm.com>

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Cédric Le Goater]

On 5/10/26 10:43, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
> 
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
> 
> Please ignore the previous version.
> 
> GuoHan Zhao (2):
>    vfio/ap: Return false when IRQ notifier setup fails
>    vfio/ccw: Return false when IRQ notifier setup fails
> 
>   hw/vfio/ap.c  | 1 +
>   hw/vfio/ccw.c | 1 +
>   2 files changed, 2 insertions(+)
> 


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Matthew Rosato]

On 5/10/26 4:43 AM, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
> 
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
> 
> Please ignore the previous version.
> 
> GuoHan Zhao (2):
>   vfio/ap: Return false when IRQ notifier setup fails
>   vfio/ccw: Return false when IRQ notifier setup fails
> 
>  hw/vfio/ap.c  | 1 +
>  hw/vfio/ccw.c | 1 +
>  2 files changed, 2 insertions(+)
> 

For the series:

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Cornelia Huck]

On Sun, May 10 2026, zhaoguohan@kylinos.cn wrote:

> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
>
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
>
> Please ignore the previous version.
>
> GuoHan Zhao (2):
>   vfio/ap: Return false when IRQ notifier setup fails
>   vfio/ccw: Return false when IRQ notifier setup fails
>
>  hw/vfio/ap.c  | 1 +
>  hw/vfio/ccw.c | 1 +
>  2 files changed, 2 insertions(+)
>

...I guess this should go through the s390 tree (and not the vfio tree?)
If yes, I'll pick it up.

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Cédric Le Goater]

On 5/28/26 16:55, Cornelia Huck wrote:
> On Sun, May 10 2026, zhaoguohan@kylinos.cn wrote:
> 
>> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>>
>> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
>> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
>> fails, but still return true to their callers.
>>
>> Return false after cleanup so callers can handle the failed registration
>> path instead of treating it as a successful notifier setup.
>>
>> Please ignore the previous version.
>>
>> GuoHan Zhao (2):
>>    vfio/ap: Return false when IRQ notifier setup fails
>>    vfio/ccw: Return false when IRQ notifier setup fails
>>
>>   hw/vfio/ap.c  | 1 +
>>   hw/vfio/ccw.c | 1 +
>>   2 files changed, 2 insertions(+)
>>
> 
> ...I guess this should go through the s390 tree (and not the vfio tree?)
> If yes, I'll pick it up.
> 

I included these patches in my VFIO PR  last week. They are merged.

   https://lore.kernel.org/qemu-devel/20260520162115.1613601-1-clg@redhat.com/

Hope that's fine ? Sorry if not :/

C.

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

[Cornelia Huck]

On Thu, May 28 2026, Cédric Le Goater <clg@redhat.com> wrote:

> On 5/28/26 16:55, Cornelia Huck wrote:
>> On Sun, May 10 2026, zhaoguohan@kylinos.cn wrote:
>> 
>>> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
>>>
>>> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
>>> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
>>> fails, but still return true to their callers.
>>>
>>> Return false after cleanup so callers can handle the failed registration
>>> path instead of treating it as a successful notifier setup.
>>>
>>> Please ignore the previous version.
>>>
>>> GuoHan Zhao (2):
>>>    vfio/ap: Return false when IRQ notifier setup fails
>>>    vfio/ccw: Return false when IRQ notifier setup fails
>>>
>>>   hw/vfio/ap.c  | 1 +
>>>   hw/vfio/ccw.c | 1 +
>>>   2 files changed, 2 insertions(+)
>>>
>> 
>> ...I guess this should go through the s390 tree (and not the vfio tree?)
>> If yes, I'll pick it up.
>> 
>
> I included these patches in my VFIO PR  last week. They are merged.
>
>    https://lore.kernel.org/qemu-devel/20260520162115.1613601-1-clg@redhat.com/
>
> Hope that's fine ? Sorry if not :/

Completely fine, thx, I just overlooked it :)