* [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()
@ 2026-05-26 10:41 Helge Deller
2026-05-26 10:49 ` Peter Maydell
2026-05-26 10:55 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Helge Deller @ 2026-05-26 10:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Helge Deller
From: Helge Deller <deller@gmx.de>
The third parameter is called guest_hiaddr.
Signed-off-by: Helge Deller <deller@gmx.de>
---
linux-user/elfload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 0e757787d2..f7625c0952 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
* pgb_addr_set:
* @ga: output set of guest addrs
* @guest_loaddr: guest image low address
- * @guest_loaddr: guest image high address
+ * @guest_hiaddr: guest image high address
* @identity: create for identity mapping
*
* Fill in @ga with the image, COMMPAGE and NULL page.
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()
2026-05-26 10:41 [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set() Helge Deller
@ 2026-05-26 10:49 ` Peter Maydell
2026-05-26 10:55 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2026-05-26 10:49 UTC (permalink / raw)
To: Helge Deller; +Cc: qemu-devel, Helge Deller
On Tue, 26 May 2026 at 11:41, Helge Deller <deller@kernel.org> wrote:
>
> From: Helge Deller <deller@gmx.de>
>
> The third parameter is called guest_hiaddr.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> linux-user/elfload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 0e757787d2..f7625c0952 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
> * pgb_addr_set:
> * @ga: output set of guest addrs
> * @guest_loaddr: guest image low address
> - * @guest_loaddr: guest image high address
> + * @guest_hiaddr: guest image high address
> * @identity: create for identity mapping
> *
> * Fill in @ga with the image, COMMPAGE and NULL page.
> --
> 2.54.0
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()
2026-05-26 10:41 [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set() Helge Deller
2026-05-26 10:49 ` Peter Maydell
@ 2026-05-26 10:55 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2026-05-26 10:55 UTC (permalink / raw)
To: Helge Deller; +Cc: qemu-devel, Helge Deller
Helge Deller <deller@kernel.org> writes:
> From: Helge Deller <deller@gmx.de>
>
> The third parameter is called guest_hiaddr.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> linux-user/elfload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 0e757787d2..f7625c0952 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
> * pgb_addr_set:
> * @ga: output set of guest addrs
> * @guest_loaddr: guest image low address
> - * @guest_loaddr: guest image high address
> + * @guest_hiaddr: guest image high address
> * @identity: create for identity mapping
> *
> * Fill in @ga with the image, COMMPAGE and NULL page.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-26 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 10:41 [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set() Helge Deller
2026-05-26 10:49 ` Peter Maydell
2026-05-26 10:55 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.