All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2] irqchip/mbigen: add COMPILE_TEST support
@ 2026-05-10 19:52 Rosen Penev
  2026-05-11 14:15 ` Thomas Gleixner
  0 siblings, 1 reply; 3+ messages in thread
From: Rosen Penev @ 2026-05-10 19:52 UTC (permalink / raw)
  To: linux-kernel; +Cc: Thomas Gleixner

Add description to bool to do so.

Remove ARM_GIC_V3 as the driver does not need it to compile.

Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.

Assisted-by: Codex-GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v2: add GENERIC_MSI_IRQ
 drivers/irqchip/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index eb8428d9fa61..e7d559472790 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -208,9 +208,9 @@ config FARADAY_FTINTC010
 	select SPARSE_IRQ
 
 config HISILICON_IRQ_MBIGEN
-	bool
-	select ARM_GIC_V3
-	select ARM_GIC_V3_ITS
+	bool "HiSilicon MBIGEN interrupt controller"
+	depends on ARCH_HISI || COMPILE_TEST
+	select GENERIC_MSI_IRQ
 
 config IMGPDC_IRQ
 	bool
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] irqchip/mbigen: add COMPILE_TEST support
  2026-05-10 19:52 [PATCHv2] irqchip/mbigen: add COMPILE_TEST support Rosen Penev
@ 2026-05-11 14:15 ` Thomas Gleixner
  2026-05-13  0:52   ` Rosen Penev
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2026-05-11 14:15 UTC (permalink / raw)
  To: Rosen Penev, linux-kernel

On Sun, May 10 2026 at 12:52, Rosen Penev wrote:
> Add description to bool to do so.
>
> Remove ARM_GIC_V3 as the driver does not need it to compile.

True, but you fail to explain that GIC_V3* is always selected for ARM64
builds.

> Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.

That's not a sensible explanation either. It's required for COMPILE_TEST
builds because it's not longer selected by the removed ARM_GIC_V3_ITS.

> Assisted-by: Codex-GPT-5.5

This thing clearly lacks any competence for writing comprehensible
change logs.

What a waste of time and energy.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] irqchip/mbigen: add COMPILE_TEST support
  2026-05-11 14:15 ` Thomas Gleixner
@ 2026-05-13  0:52   ` Rosen Penev
  0 siblings, 0 replies; 3+ messages in thread
From: Rosen Penev @ 2026-05-13  0:52 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-kernel

On Mon, May 11, 2026 at 7:15 AM Thomas Gleixner <tglx@kernel.org> wrote:
>
> On Sun, May 10 2026 at 12:52, Rosen Penev wrote:
> > Add description to bool to do so.
> >
> > Remove ARM_GIC_V3 as the driver does not need it to compile.
>
> True, but you fail to explain that GIC_V3* is always selected for ARM64
> builds.
OK.
>
> > Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.
>
> That's not a sensible explanation either. It's required for COMPILE_TEST
> builds because it's not longer selected by the removed ARM_GIC_V3_ITS.
OK.
>
> > Assisted-by: Codex-GPT-5.5
>
> This thing clearly lacks any competence for writing comprehensible
> change logs.
User error. AGENTS.md needs tweaking locally. Speaking of which it
would probably make sense to commit one here similar to .clang-format.
>
> What a waste of time and energy.
Not my call. I've found it very useful to avoid having to resend
multiple patches because of a boneheaded description.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-13  0:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-10 19:52 [PATCHv2] irqchip/mbigen: add COMPILE_TEST support Rosen Penev
2026-05-11 14:15 ` Thomas Gleixner
2026-05-13  0:52   ` Rosen Penev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.