Re: [PATCH Dovetail 6.16 v3 3/3] irq_pipeline: Fix pipelining code for level triggered IRQs

[Philippe Gerum <rpm@xenomai.org>]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> During the last forward port to 6.16 the pipelining code was
> accidentally removed from handle_level_irq().
>
> Forward porting the (old) code from 6.15 again to fix this problem.
>
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  kernel/irq/chip.c | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 8a0831193d74..f5dfc378ccf2 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -846,15 +846,33 @@ static void cond_unmask_irq(struct irq_desc *desc)
>   */
>  void handle_level_irq(struct irq_desc *desc)
>  {
> +	int flow;
> +
>  	guard(hybrid_spinlock)(&desc->lock);
> -	mask_ack_irq(desc);
>  
> -	if (!irq_can_handle(desc))
> +	flow = get_flow_step(desc);
> +	if (may_start_flow(flow)) {
> +		mask_ack_irq(desc);
> +
> +		if (!irq_can_handle(desc))
> +			return;
> +	}
> +
> +	if (should_feed_pipeline(desc, flow)) {
> +		if (handle_oob_irq(desc))
> +			goto out_unmask;
> +		return;
> +	}
> +
> +	if (flow == IRQ_FLOW_FORWARD) {
> +		forward_irq_event(desc);
>  		return;
> +	}
>  
>  	kstat_incr_irqs_this_cpu(desc);
>  	handle_irq_event(desc);
>  
> +out_unmask:
>  	cond_unmask_irq(desc);
>  }
>  EXPORT_SYMBOL_GPL(handle_level_irq);

Ack.

-- 
Philippe.