Re: [PATCH Dovetail 6.16 v3 1/3] x86/fpu: dovetail: Fix FPU corruption

[Philippe Gerum <rpm@xenomai.org>]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index 77c4c632cef2..2fc72d622229 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -237,10 +237,11 @@ static inline int arch_within_stack_frames(const void * const stack,
>  #define TS_OFFSTAGE		0x0040	/* Thread is in-flight to OOB context */
>  #define TS_OOBTRAP		0x0080	/* Handling a trap from OOB context */
>  
> -#define _TLF_OOB		TS_OOB
> -#define _TLF_DOVETAIL		TS_DOVETAIL
> -#define _TLF_OFFSTAGE		TS_OFFSTAGE
> -#define _TLF_OOBTRAP		TS_OOBTRAP
> +#define _TLF_OOB			TS_OOB
> +#define _TLF_DOVETAIL			TS_DOVETAIL
> +#define _TLF_OFFSTAGE			TS_OFFSTAGE
> +#define _TLF_OOBTRAP			TS_OOBTRAP
> +#define _TLF_KERNEL_FPU_PREEMPTED	0x0100	/* Dovetail: kernel mode FPU section preempted by OOB */
>

The TS_* enumeration originates from the upstream implementation, so we
added our thread-synchronous flags there. The _TLF_* aliasing comes from
the Dovetail implementation, in order to get a common naming scheme
because not all archs would define TS_* flags. So we should keep it the
current way which is intended to prevent conflicting upstream addition
to go unnoticed, i.e. define TS_KERNEL_FPU_PREEMPTED then alias it to
_TLF_KERNEL_FPU_PREEMPTED.

The rest looks good to me.


-- 
Philippe.