[Buildroot] [PATCH 1/1] package/libunistring: Skip 'tests' dir when building

[Buildroot] [PATCH 1/1] package/libunistring: Skip 'tests' dir when building

[Pedro Aguilar]

The tests/ dir gives different types of linking errors when building
under different archs and with different C libs such as libc and musl.
This dir is not necessary when building and it can be safely skipped,
so let's remove it from the building process.

This fixes the building errors reported here:
https://autobuild.buildroot.org/results/770ac5653ee832a9117a7cd288a193750dfcfe29
https://autobuild.buildroot.org/results/a31d608388b0ff28334f674baeb501b023bdb4bf
https://autobuild.buildroot.org/results/f5a833a3dcd7094290fcbc6b8989620749bc6316
https://autobuild.buildroot.org/results/b572db1524de16006d55a42dca43a0a500f78ed0
https://autobuild.buildroot.org/results/a155a54b30f6cb02d74687992088f543fa63cb74
https://autobuild.buildroot.org/results/dfe061ddaa9ef0b6e39b2da20858baa36ae1fca2

Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
---
 .../0001-Makefile-do-not-build-tests-dir.patch        | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 package/libunistring/0001-Makefile-do-not-build-tests-dir.patch

diff --git a/package/libunistring/0001-Makefile-do-not-build-tests-dir.patch b/package/libunistring/0001-Makefile-do-not-build-tests-dir.patch
new file mode 100644
index 0000000000..b1ef642224
--- /dev/null
+++ b/package/libunistring/0001-Makefile-do-not-build-tests-dir.patch
@@ -0,0 +1,11 @@
+--- a/Makefile.in	2024-10-16 13:33:55.000000000 +0200
++++ b/Makefile.in	2025-03-16 18:40:35.108110641 +0100
+@@ -2351,7 +2351,7 @@
+ top_srcdir = @top_srcdir@
+ AUTOMAKE_OPTIONS = 1.5 gnu no-dependencies
+ ACLOCAL_AMFLAGS = -I m4 -I gnulib-m4
+-SUBDIRS = doc gnulib-local lib tests
++SUBDIRS = doc gnulib-local lib
+
+ # Allow users to use "gnulib-tool --update".
+
--
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libunistring: Skip 'tests' dir when building

[Peter Korsgaard]

>>>>> "Pedro" == Pedro Aguilar <paguilar@paguilar.org> writes:

 > The tests/ dir gives different types of linking errors when building
 > under different archs and with different C libs such as libc and musl.
 > This dir is not necessary when building and it can be safely skipped,
 > so let's remove it from the building process.

 > This fixes the building errors reported here:
 > https://autobuild.buildroot.org/results/770ac5653ee832a9117a7cd288a193750dfcfe29
 > https://autobuild.buildroot.org/results/a31d608388b0ff28334f674baeb501b023bdb4bf
 > https://autobuild.buildroot.org/results/f5a833a3dcd7094290fcbc6b8989620749bc6316
 > https://autobuild.buildroot.org/results/b572db1524de16006d55a42dca43a0a500f78ed0
 > https://autobuild.buildroot.org/results/a155a54b30f6cb02d74687992088f543fa63cb74
 > https://autobuild.buildroot.org/results/dfe061ddaa9ef0b6e39b2da20858baa36ae1fca2

 > Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>

Thanks. How about instead adding a --disable-tests option so this patch
can be upstreamed?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot